Re: [PATCH] "PowerPC64" chacha-core big-endian support "Shorter version"

2020-09-28 Thread Niels Möller
ni...@lysator.liu.se (Niels Möller) writes: > Maamoun TK writes: > >> The last patch follows the C implementation but I just figured out a decent >> way to do it. > > Thanks! Applied, and pushed on the ppc-chacha-core branch for testing. > (Had apply it semi-manually, since the file to patch

Re: [PATCH] "PowerPC64" GCM support

2020-09-28 Thread Niels Möller
Maamoun TK writes: Thanks for the update. This is quite complex for me. I have not yet read the code very carefully. I think I'd like to focus on the main function, gcm_hash, first. Some questions and suggestions, to make it easier: 1. Take out the fat support to it's own patch. 2. You could

Re: [PATCH] "PowerPC64" GCM support

2020-09-28 Thread Niels Möller
Maamoun TK writes: > I posted a performance test here > https://lists.lysator.liu.se/pipermail/nettle-bugs/2020/009169.html > Personally, I prefer keeping the altivec version in nettle library since > it's faster than C implementation but I'm not sure whether the performance > margin fits with

Re: [PATCH] "PowerPC64" chacha-core big-endian support "Shorter version"

2020-09-28 Thread Niels Möller
Maamoun TK writes: > The last patch follows the C implementation but I just figured out a decent > way to do it. Thanks! Applied, and pushed on the ppc-chacha-core branch for testing. (Had apply it semi-manually, since the file to patch indents using TAB and those were replaced by spaces in the

Re: [PATCH] "PowerPC64" GCM support

2020-09-28 Thread Maamoun TK
I posted a performance test here https://lists.lysator.liu.se/pipermail/nettle-bugs/2020/009169.html Personally, I prefer keeping the altivec version in nettle library since it's faster than C implementation but I'm not sure whether the performance margin fits with the library's convention of