Corentin Labbe <clabbe.montj...@gmail.com> writes:
> Since new shaxxx_compress functions were added, it is time to add
> documenation for it along documentation for old md5/sha1_compress.
Thanks. A few comments below. Let me know if you can do yet another
revision, otherwise, I'll do the suggested edits when I apply the patch.
> +@deftypefun void sha256_compress (const uint32_t *@var{state}, uint8_t
> *@var{input})
> +Perform a raw SHA256 compress on SHA256_BLOCK_SIZE bytes from
> @var{input} using @var{state} as IV (which should be at
> +least 8 uint32_t long). The output is stored in @var{state}.
I'd strike "at least", state should be an array of exactly 8 uint32_t.
> +This function provides access to the underlying compression function,
> +for the rare applications that need that, (like using different IV from
> +standard SHA256)
Nit: For the last parenthesis, either strike the comma, "...need that
(like using ...)", or rephrase as "need that, e.g., using...". And
final period is missing.
> +@deftypefun void sha224_compress (const uint32_t *@var{state}, uint8_t
> *@var{input})
Hmm, there is no sha224_compress (or sha384_compress), right?
Since these hash functions use the same compression as sha256 and
sha512, respectively.
Regards,
/Niels
--
Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677.
Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se
To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se
