Zoltan Fridrich <zfrid...@redhat.com> writes: > Thank you for another review. I have finalized the balloon.patch. > Changes made: > > - fixed formatting > - increased return value of balloon_itch to include the "block" local > variable at the beginning of scratch > - wrappers moved to separate source files > - tests expanded to test balloon_shaXXX functions
Thanks, merged to a new branch, "balloon", for testing. I note you have a redhat email address, but copyright notices say you rather than redhat own copyright to these changes. Is that as intended? Minor note: In the tests, I think it's perfectly fine to leak memory in the failure case, so it's fine to call FAIL or ASSERT directly, without first freeing memory. Regards, /Niels -- Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se
