Re: Possible bug of cnd_copy

2023-11-09 Thread NIIBE Yutaka
Hello, NIIBE Yutaka wrote: > I can test with Clang 17. I'll test. The particular tests (using valgrind) do not fail with Clang 17. I checked the assembler output, and confirmed no issues. With artifically modified source (so that it can replicate cnd_copy problem): ==

Re: Possible bug of cnd_copy

2023-11-09 Thread NIIBE Yutaka
Hello, Niels Möller wrote: > 1. Do the changes on branch >https://git.lysator.liu.se/nettle/nettle/-/tree/sc-is_zero?ref_type=heads >help? Yes. It helps. I confirmed the function cnd_copy has no problem with the change (removing != 0, and require callers to use 0/1), for the cases I

Re: Possible bug of cnd_copy

2023-11-09 Thread Niels Möller
NIIBE Yutaka writes: > I checked other compilers today. Thanks for investigating! Questions: 1. Do the changes on branch https://git.lysator.liu.se/nettle/nettle/-/tree/sc-is_zero?ref_type=heads help? 2. If you install valgrind (including header files), do the recently added tests