Re: [PATCH] nettle-types: drop w field from nettle_block16

2019-07-04 Thread Dmitry Eremin-Solenikov
Hello, чт, 4 июл. 2019 г. в 10:06, Niels Möller : > > Dmitry Eremin-Solenikov writes: > > > Hmm. This patch has to wait a bit, sent it without actual testing. > > nettle_block16.w is used by eax (easy to copy with) and gcm > > (might need performance checks on 32-bit architectures). > > I would

Re: [PATCH] nettle-types: drop w field from nettle_block16

2019-07-04 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > Hmm. This patch has to wait a bit, sent it without actual testing. > nettle_block16.w is used by eax (easy to copy with) and gcm > (might need performance checks on 32-bit architectures). I would expect that using the uint64_t field is as efficient (or better,

Re: [PATCH] nettle-types: drop w field from nettle_block16

2019-07-03 Thread Dmitry Eremin-Solenikov
Hmm. This patch has to wait a bit, sent it without actual testing. nettle_block16.w is used by eax (easy to copy with) and gcm (might need performance checks on 32-bit architectures). ср, 3 июл. 2019 г. в 00:45, Dmitry Eremin-Solenikov : > > "unsigned long w" comes from the time when Nettle

[PATCH] nettle-types: drop w field from nettle_block16

2019-07-02 Thread Dmitry Eremin-Solenikov
"unsigned long w" comes from the time when Nettle didn't use uint64_t. It is unused now and thus can be dropped. Signed-off-by: Dmitry Eremin-Solenikov --- nettle-types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/nettle-types.h b/nettle-types.h index 5addf3600d69..93a68f3b305c 100644