Re: [PATCH v3] CCM Cipher Modes

2014-03-23 Thread Niels Möller
Owen Kirby writes: > Latest round of changes to the CCM modes, this moves the processing of L(a) > into > ccm_set_nonce() and updates the all-at-once API to concatenate the ciphertext > and > digest together. Pushed now, with some smaller changes. All uses of nettle_crypt_func are replaced by

Re: [PATCH v3] CCM Cipher Modes

2014-03-24 Thread Owen Kirby
Awesome, thank you. I will take a look at assembling documentation regarding the CCM modes when I get some spare time this week. Cheers, Owen On 14-03-23 11:06 AM, Niels Möller wrote: > Owen Kirby writes: > >> Latest round of changes to the CCM modes, this moves the processing of L(a) >> into >

Re: [PATCH v3] CCM Cipher Modes

2014-04-11 Thread Niels Möller
ni...@lysator.liu.se (Niels Möller) writes: > Pushed now, with some smaller changes. I get a couple of warnings, when compiling for 32-bit platforms, e.g., ARM. /home/nisse/hack/nettle/ccm.c: In function `nettle_ccm_set_nonce': /home/nisse/hack/nettle/ccm.c:134:3: warning: comparison is always f

Re: [PATCH v3] CCM Cipher Modes

2014-04-11 Thread Owen Kirby
Actually, that's not entirely correct. I have seen some architectures that will turn a shift into a nop when the shift width is greater than the word size. I have some ARM boards that I can cross compile for, so I'll take a look at cleaning up the warnings when I get some time this weekend. Thanks

Re: [PATCH v3] CCM Cipher Modes

2014-04-11 Thread Niels Möller
Owen Kirby writes: > Actually, that's not entirely correct. I have seen some architectures > that will turn a shift into a nop when the shift width is greater than > the word size. Shifts greater than the word size can give different types of undefined behaviour. Ignoring higher bits of the shif

Re: [PATCH v3] CCM Cipher Modes

2014-05-03 Thread Niels Möller
ni...@lysator.liu.se (Niels Möller) writes: > I get a couple of warnings, when compiling for 32-bit platforms, e.g., > ARM. > > /home/nisse/hack/nettle/ccm.c: In function `nettle_ccm_set_nonce': > /home/nisse/hack/nettle/ccm.c:134:3: warning: comparison is always > false due to limited range of da