Re: Leak reduction

2005-04-14 Thread Jonathan Blandford
Tom Parker <[EMAIL PROTECTED]> writes: > + if (received_bytes!=NULL) > + g_free(received_bytes); Minor style quibble: g_free() checks for NULL anyway. You can just put g_free (received_bytes); -Jonathan ___ NetworkManager-list mailing

More cleanup (worker thread)

2005-04-14 Thread Tom Parker
The nm_device_worker() thread within NetworkManagerDevice is checked for shutdown by polling worker_done repeatedly. This is a) inefficient, and b) doesn't ever clean up the GThread* and associated things properly. I've fixed this by using g_thread_join() to wait for completion instead. Patch at

SyncScan algorithm

2005-04-14 Thread Bret Mogilefsky
Hi, Thought I'd bring this up on the list as I can see that this may be applicable for NetworkManager... http://www.eurekalert.org/pub_releases/2005-04/uoc--fhb041305.php Precis: Faster handoff between Wi-Fi networks promises near-seamless 802.11 roaming Road warriors may no longer have to stay p

Leak reduction

2005-04-14 Thread Tom Parker
Running NetworkManager through valgrind turned up a whole bunch of leaks, some of which I've managed to fix with the attached patch. There's still a fair amount of work to be done here, but part of the problem is current limitations in the Dbus and glib APIs for properly freeing no longer needed