Re: [PATCH] default VPN import/export path to home directory

2011-09-27 Thread Dan Williams
On Tue, 2011-09-27 at 10:19 -0400, Mathieu Trudel-Lapierre wrote: > Hi, > > In previous versions of nm-applet on Ubuntu we could notice the > default path for import and export of VPN configs being the user's > home directory. > > Looking again, this doesn't appear to be the case in Oneiric, poss

Re: PATCH] sms_decode_text(): Sanitize 8-bit data so that it is UTF8-clean.

2011-09-27 Thread Dan Williams
On Tue, 2011-09-27 at 14:55 -0400, Nathan Williams wrote: > > > On Tue, Sep 27, 2011 at 2:18 PM, Dan Williams wrote: > On Mon, 2011-09-26 at 18:29 -0400, Nathan Williams wrote: > > This keeps ModemManager from crashing deep in the DBus > libraries when > > a SMS G

Re: PATCH] sms_decode_text(): Sanitize 8-bit data so that it is UTF8-clean.

2011-09-27 Thread Nathan Williams
On Tue, Sep 27, 2011 at 2:18 PM, Dan Williams wrote: > On Mon, 2011-09-26 at 18:29 -0400, Nathan Williams wrote: > > This keeps ModemManager from crashing deep in the DBus libraries when > > a SMS Get() or List() DBus operation finds a message that isn't valid > > UTF-8 and/or has embedded NUL ch

Re: [PATCH] ModemManager: Clean up GRegex/GMatchInfo leaks

2011-09-27 Thread Dan Williams
On Tue, 2011-09-27 at 12:54 -0400, Nathan Williams wrote: > During some other development we found that there was a lot of > inconsistency in freeing GMatchInfo structures after g_regex > operations, and that quite a few match_info structures were probably > being leaked. This patch is the result o

Re: PATCH] sms_decode_text(): Sanitize 8-bit data so that it is UTF8-clean.

2011-09-27 Thread Dan Williams
On Tue, 2011-09-27 at 13:18 -0500, Dan Williams wrote: > On Mon, 2011-09-26 at 18:29 -0400, Nathan Williams wrote: > > This keeps ModemManager from crashing deep in the DBus libraries when > > a SMS Get() or List() DBus operation finds a message that isn't valid > > UTF-8 and/or has embedded NUL ch

Re: PATCH] sms_decode_text(): Sanitize 8-bit data so that it is UTF8-clean.

2011-09-27 Thread Andrew Bird (Sphere Systems)
On Tuesday 27 September 2011, Dan Williams wrote: > On Mon, 2011-09-26 at 18:29 -0400, Nathan Williams wrote: > > This keeps ModemManager from crashing deep in the DBus libraries when > > a SMS Get() or List() DBus operation finds a message that isn't valid > > UTF-8 and/or has embedded NUL charact

Re: PATCH] sms_decode_text(): Sanitize 8-bit data so that it is UTF8-clean.

2011-09-27 Thread Dan Williams
On Mon, 2011-09-26 at 18:29 -0400, Nathan Williams wrote: > This keeps ModemManager from crashing deep in the DBus libraries when > a SMS Get() or List() DBus operation finds a message that isn't valid > UTF-8 and/or has embedded NUL characters. > > I'll be putting up a separate patch as a proposa

[PATCH] ModemManager: Clean up GRegex/GMatchInfo leaks

2011-09-27 Thread Nathan Williams
During some other development we found that there was a lot of inconsistency in freeing GMatchInfo structures after g_regex operations, and that quite a few match_info structures were probably being leaked. This patch is the result of a quick audit of the g_regex callers for properly cleaning up th

Re: [PATCH] clean up mobile broadband wizard

2011-09-27 Thread Dan Williams
On Tue, 2011-09-27 at 16:43 +0100, Bastien Nocera wrote: > On Tue, 2011-09-27 at 10:00 -0400, Mathieu Trudel-Lapierre wrote: > > Hi, > > > > I noticed many duplicate buttons and page headers in the mobile > > broadband wizard, attached is a patch that fixes this. > > It was a bug in GTK+, which I

[PATCH 3/3] core: split nm_manager_get() to simplify manager creation

2011-09-27 Thread Dan Williams
OLPC Mesh code now doesn't have to be updated every time we change the manager's creation arguments. We could make all these arguments GObject properties of the manager too, but that's more code and we'd eventually like to figure out a better solution for letting non-NMManager code listen for devi

[PATCH 2/3] core: split out config file handling

2011-09-27 Thread Dan Williams
Make config file stuff somewhat clearer and easier to understand, and possibly easier to extend later. --- src/Makefile.am|2 + src/main.c | 135 + src/nm-config.c| 243 src/nm-config

[PATCH 1/3] core: remove unused arguments from nm_manager_get()

2011-09-27 Thread Dan Williams
They weren't used. --- src/main.c|2 -- src/nm-device-olpc-mesh.c |6 +++--- src/nm-manager.c |5 - src/nm-manager.h |2 -- 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/src/main.c b/src/main.c index 328c253..a9ffd38 100644 -

Re: [PATCH] clean up mobile broadband wizard

2011-09-27 Thread Bastien Nocera
On Tue, 2011-09-27 at 10:00 -0400, Mathieu Trudel-Lapierre wrote: > Hi, > > I noticed many duplicate buttons and page headers in the mobile > broadband wizard, attached is a patch that fixes this. It was a bug in GTK+, which I fixed in time for GNOME 3.2 last week. Cheers __

[PATCH 0/3] clean up config file handling

2011-09-27 Thread Dan Williams
Split config file reading and handling out of main.c so that it's easier to extend later on. ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list

[PATCH] default VPN import/export path to home directory

2011-09-27 Thread Mathieu Trudel-Lapierre
Hi, In previous versions of nm-applet on Ubuntu we could notice the default path for import and export of VPN configs being the user's home directory. Looking again, this doesn't appear to be the case in Oneiric, possibly because of changes in GTK. The attached patch defines the current directory

[PATCH] clean up mobile broadband wizard

2011-09-27 Thread Mathieu Trudel-Lapierre
Hi, I noticed many duplicate buttons and page headers in the mobile broadband wizard, attached is a patch that fixes this. Mathieu Trudel-Lapierre Freenode: cyphermox, Jabber: mathieu...@gmail.com 4096R/EE018C93 1967 8F7D 03A1 8F38 732E  FF82 C126 33E1 EE01 8C93 From: Mathieu Trudel-Lapierre Su

NM 0.9 asks for PK auth without need

2011-09-27 Thread Ludwig Nussel
Hi, 802.11x connections that are configured to always prompt for the password also always require polkit authentication (bgo#646187). I tried to find out why but got stuck. AFAICS one culprit is has_system_secrets() in src/settings/nm-agent-manager.c. It iterates over all properties of a connecti