Re: [PATCH] keyfile: include '\0' when copying string to array

2011-09-30 Thread Gary Ching-Pang Lin
2011/9/30 Dan Williams d...@redhat.com: On Fri, 2011-09-23 at 18:15 +0800, Gary Ching-Pang Lin wrote: This commit fixes the corrupted string in the copied array by including '\0' in the orignal string. This function gets used for SSIDs too though, and they can't have a trailing NULL.  So we

Re: [PATCH] Re: Wired + Wireless cohexistence issues, using libnl3

2011-09-30 Thread Thomas Graf
On Thu, 2011-09-29 at 18:09 -0500, Dan Williams wrote: On Wed, 2011-09-28 at 12:09 -0400, Mathieu Trudel-Lapierre wrote: So I actually found the cause for the missing routes in the libnl cache: in nm_netlink_foreach_route(), when rtnl_route_alloc_cache() is called, it is done with the

[PATCH 1/8] api: include ScanDevices() and SetLogging() in the new manager API

2011-09-30 Thread Aleksander Morgado
These methods were available in the old API, and are needed in the new one. --- new/org.freedesktop.ModemManager1.xml | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/new/org.freedesktop.ModemManager1.xml b/new/org.freedesktop.ModemManager1.xml index

[PATCH 3/8] api: let the Modem expose a 'Sim' property to link to a specific SIM object

2011-09-30 Thread Aleksander Morgado
SIM objects will be listed as independent objects in the DBus API, and the 'Sim' property in a given modem object will specify which SIM object is in use. --- new/org.freedesktop.ModemManager1.Modem.xml |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

Changes to the proposed ModemManager DBus API

2011-09-30 Thread Aleksander Morgado
Here is a set of changes to the proposed MM DBus API. Some of them were already discussed some time ago in the following thread: https://mail.gnome.org/archives/networkmanager-list/2011-May/msg00162.html [PATCH 1/8] api: include ScanDevices() and SetLogging() in the new manager API [PATCH 2/8]

[PATCH 2/8] api: remove GetInfo() from the Modem API and use read-only properties instead.

2011-09-30 Thread Aleksander Morgado
New 'Manufacturer', 'Model' and 'Revision properties are added, all being read-only strings. --- new/org.freedesktop.ModemManager1.Modem.xml | 37 +-- 1 files changed, 18 insertions(+), 19 deletions(-) diff --git a/new/org.freedesktop.ModemManager1.Modem.xml

[PATCH 4/8] api: let SignalQuality say if the given value was recently taken

2011-09-30 Thread Aleksander Morgado
Modems which only expose a single port will not be able to update the signal quality value while in connected mode. The signal quality value reported in this case, while the modem is connected, will be the last signal quality value read before the connection. The additional boolean value proposed

[PATCH 8/8] api: Let MM_MODEM_MODE be a bitfield, and new PreferredMode property

2011-09-30 Thread Aleksander Morgado
Supported and Allowed modes are modified to be bitmasks of MM_MODEM_MODE values, and preference of a specific mode is now given in the new PreferredMode property and as an extra argument to the SetAllowedModes() call. * Supported Modes: bitmask specifying which modes are supported by the

[PATCH 7/8] api: rename MM_MODEM_ALLOWED_MODE to MM_MODEM_MODE

2011-09-30 Thread Aleksander Morgado
Makes more sense to have the enum named just as 'mode', as it applies to both Supported and Allowed. --- new/org.freedesktop.ModemManager1.Modem.xml |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/new/org.freedesktop.ModemManager1.Modem.xml

[PATCH 5/8] api: new SetAllowedModes() to be able to modify the allowed mode in the modem

2011-09-30 Thread Aleksander Morgado
Changing the allowed mode of a modem may fail, for example if trying to set a mode which is not in the modes reported as Supported by the modem. Therefore, we need an explicit SetAllowedModes() method with proper error reporting instead of making the property writable. ---

[PATCH 6/8] api: new SetAllowedBands() to be able to modify the allowed bands in the modem

2011-09-30 Thread Aleksander Morgado
Changing the allowed bands in a modem may fail, for example if trying to set a frequency band which is not in the bands mask reported as Supported by the modem. Therefore, we need an explicit SetAllowedBands() method with proper error reporting instead of making the property writable. ---

Re: Problem with auto connect to WLAN

2011-09-30 Thread Christian Ehrlicher
Am Freitag, 30. September 2011, 07:40:39 schrieben Sie: On Wed, 2011-09-21 at 10:55 +0200, Christian Ehrlicher wrote: Hello, I've a system config to automatically connect to a wlan. This works fine for the first start of the network manager. Once the wlan isn't available (the wlan

Re: [PATCH] core: improving handling of rfkill

2011-09-30 Thread Dan Williams
On Tue, 2011-09-20 at 16:36 +0800, Gary Ching-Pang Lin wrote: This commit improves the handling of rfkill. - The original two passes check gathers the states of platform and non-platform switches in two separate loops. Now we gather the both states in one loop and determine the final

Re: 0.9 problem

2011-09-30 Thread Алекс Скоропад
30.09.2011 08:02, Dan Williams пишет: On Sun, 2011-09-25 at 19:11 +0300, Алекс Скоропад wrote: Here they are: Daemon.log - http://goo.gl/gf0q3 wpa_supplicant.log - http://goo.gl/VCEqA In this case, can you add the following to /etc/NetworkManager/NetworkManager.conf ? [logging] level=DEBUG

Re: 0.9 problem

2011-09-30 Thread Алекс Скоропад
30.09.2011 08:02, Dan Williams пишет: On Sun, 2011-09-25 at 19:11 +0300, Алекс Скоропад wrote: Here they are: Daemon.log - http://goo.gl/gf0q3 wpa_supplicant.log - http://goo.gl/VCEqA In this case, can you add the following to /etc/NetworkManager/NetworkManager.conf ? [logging] level=DEBUG

Re: 0.9 problem

2011-09-30 Thread Dan Williams
On Fri, 2011-09-30 at 20:03 +0300, Алекс Скоропад wrote: 30.09.2011 08:02, Dan Williams пишет: On Sun, 2011-09-25 at 19:11 +0300, Алекс Скоропад wrote: Here they are: Daemon.log - http://goo.gl/gf0q3 wpa_supplicant.log - http://goo.gl/VCEqA In this case, can you add the following to

Re: 0.9 problem

2011-09-30 Thread Алекс Скоропад
30.09.2011 20:23, Dan Williams пишет: On Fri, 2011-09-30 at 20:03 +0300, Алекс Скоропад wrote: 30.09.2011 08:02, Dan Williams пишет: On Sun, 2011-09-25 at 19:11 +0300, Алекс Скоропад wrote: Here they are: Daemon.log - http://goo.gl/gf0q3 wpa_supplicant.log - http://goo.gl/VCEqA In this case,

Re: 0.9 problem

2011-09-30 Thread Алекс Скоропад
30.09.2011 20:23, Dan Williams пишет: On Fri, 2011-09-30 at 20:03 +0300, Алекс Скоропад wrote: 30.09.2011 08:02, Dan Williams пишет: On Sun, 2011-09-25 at 19:11 +0300, Алекс Скоропад wrote: Here they are: Daemon.log - http://goo.gl/gf0q3 wpa_supplicant.log - http://goo.gl/VCEqA In this case,

Re: 0.9 problem

2011-09-30 Thread Алекс Скоропад
30.09.2011 21:25, Dan Williams пишет: On Fri, 2011-09-30 at 21:10 +0300, Алекс Скоропад wrote: 30.09.2011 20:23, Dan Williams пишет: On Fri, 2011-09-30 at 20:03 +0300, Алекс Скоропад wrote: 30.09.2011 08:02, Dan Williams пишет: On Sun, 2011-09-25 at 19:11 +0300, Алекс Скоропад wrote: Here

Re: [PATCH 8/8] api: Let MM_MODEM_MODE be a bitfield, and new PreferredMode property

2011-09-30 Thread Thomas Bechtold
Hi Aleksander, the changes looking great. one question about the preferred mode (see below). On Fri, 2011-09-30 at 15:01 +0200, Aleksander Morgado wrote: Supported and Allowed modes are modified to be bitmasks of MM_MODEM_MODE values, and preference of a specific mode is now given in the new

Re: [PATCH 8/8] api: Let MM_MODEM_MODE be a bitfield, and new PreferredMode property

2011-09-30 Thread Aleksander Morgado
Hey Thomas, Supported and Allowed modes are modified to be bitmasks of MM_MODEM_MODE values, and preference of a specific mode is now given in the new PreferredMode property and as an extra argument to the SetAllowedModes() call. * Supported Modes: bitmask specifying which modes

Re: [PATCH 8/8] api: Let MM_MODEM_MODE be a bitfield, and new PreferredMode property

2011-09-30 Thread Dan Williams
On Fri, 2011-09-30 at 15:01 +0200, Aleksander Morgado wrote: Supported and Allowed modes are modified to be bitmasks of MM_MODEM_MODE values, and preference of a specific mode is now given in the new PreferredMode property and as an extra argument to the SetAllowedModes() call. *

Re: Changes to the proposed ModemManager DBus API

2011-09-30 Thread Dan Williams
On Fri, 2011-09-30 at 15:01 +0200, Aleksander Morgado wrote: Here is a set of changes to the proposed MM DBus API. Some of them were already discussed some time ago in the following thread: https://mail.gnome.org/archives/networkmanager-list/2011-May/msg00162.html [PATCH 1/8] api: include

[PATCH] core: improve keyfile error handling

2011-09-30 Thread Thomas Bechtold
* better error messages * fix memory leak in parse_state_file () * create intermediate parent directories as needed for state file --- src/main.c | 30 +- src/nm-config.c | 13 ++--- 2 files changed, 23 insertions(+), 20 deletions(-) diff --git