Re: DHCP timeout on ethernet device.

2011-10-05 Thread José Queiroz
2011/10/5 Dan Williams > On Tue, 2011-10-04 at 11:44 +0200, Jiri Popelka wrote: > > You can add > > > > timeout ; > > > > to /etc/dhcp/dhclient-.conf > > > > > > See also > > > http://mail.gnome.org/archives/networkmanager-list/2011-September/msg00127.html > > That doesn't work because NM bounds

Re: [PATCH] Remove dependency on PolicyKit

2011-10-05 Thread Dan Williams
On Wed, 2011-10-05 at 17:21 +0100, David Röthlisberger wrote: > The attached patches remove the dependency on PolicyKit by supplying a > stubbed-out polkit implementation that allows every request. > > The change has been split into 2 patches: The first one has no functional > changes, and only

Re: [PATCH] Configure option --disable-crashtrace to disable GNU backtrace extensions.

2011-10-05 Thread Dan Williams
On Wed, 2011-10-05 at 17:22 +0100, David Röthlisberger wrote: > The attached patch provides a configure option to disable GNU backtrace > extensions (for non-glibc toolchains). > > The patch is off the NM_0_8 branch, but if you like it I can work on a patch > for master. Thanks, applied to both

Re: DHCP timeout on ethernet device.

2011-10-05 Thread Dan Williams
On Tue, 2011-10-04 at 11:44 +0200, Jiri Popelka wrote: > You can add > > timeout ; > > to /etc/dhcp/dhclient-.conf > > > See also > http://mail.gnome.org/archives/networkmanager-list/2011-September/msg00127.html That doesn't work because NM bounds the DHCP transaction and kills it if it runs o

Re: nm_setting_gsm_get_pin() retuns null

2011-10-05 Thread Dan Williams
On Wed, 2011-10-05 at 23:21 +0200, Anders Feder wrote: > Alternatively, can I simply request "SimIdentifier" from unlock_reply() > instead of gsm_device_added()? That way sim_id_reply() won't be invoked > unless unlock_reply() has already completed. You could chain them together that way, yes, i

Re: nm_setting_gsm_get_pin() retuns null

2011-10-05 Thread Anders Feder
Alternatively, can I simply request "SimIdentifier" from unlock_reply() instead of gsm_device_added()? That way sim_id_reply() won't be invoked unless unlock_reply() has already completed. Anders Feder On 05-10-2011 22:45, Dan Williams wrote: On Wed, 2011-10-05 at 22:12 +0200, Anders Feder wr

Re: nm_setting_gsm_get_pin() retuns null

2011-10-05 Thread Dan Williams
On Wed, 2011-10-05 at 22:12 +0200, Anders Feder wrote: > Thanks for that thorough explanation. However, I wonder if there isn't a > race condition in that implementation: if we request all three > properties in gsm_device_added(), can we be certain that we have all of > them once we are in sim_i

Re: nm_setting_gsm_get_pin() retuns null

2011-10-05 Thread Anders Feder
Thanks for that thorough explanation. However, I wonder if there isn't a race condition in that implementation: if we request all three properties in gsm_device_added(), can we be certain that we have all of them once we are in sim_id_reply()? Isn't there a risk that sim_id_reply() might be cal

Re: [PATCH 1/2] Use correct g_free() function

2011-10-05 Thread Thomas Jarosch
On 10/05/2011 07:40 PM, Dan Williams wrote: > On Tue, 2011-10-04 at 22:22 +0200, Thomas Jarosch wrote: >> Detected by cppcheck. > > Thanks, applied. Looks like the other two variables there (var1 and > var2) also need to be freed with g_free() since they are allocated using > glib functions. I'v

Re: [PATCH 8/8] api: Let MM_MODEM_MODE be a bitfield, and new PreferredMode property

2011-10-05 Thread Jason Glasgow
Sure. I've forward this request, as well as a request for full documentation of all the $NW commands to Novatel. -Jason On Wed, Oct 5, 2011 at 3:06 PM, Dan Williams wrote: > On Wed, 2011-10-05 at 13:51 -0400, Jason Glasgow wrote: > > > > > > On Mon, Oct 3, 2011 at 7:34 PM, Dan Williams wrote:

Re: [PATCH 8/8] api: Let MM_MODEM_MODE be a bitfield, and new PreferredMode property

2011-10-05 Thread Dan Williams
On Wed, 2011-10-05 at 13:51 -0400, Jason Glasgow wrote: > > > On Mon, Oct 3, 2011 at 7:34 PM, Dan Williams wrote: > On Sat, 2011-10-01 at 15:45 +0200, Aleksander Morgado wrote: > > Hey hey, > > > > > > Supported and Allowed modes are modified to be bitmasks >

Re: NM dbus API bug ?

2011-10-05 Thread Dan Williams
On Tue, 2011-10-04 at 17:07 +0200, Jean Parpaillon wrote: > Hi again :) Your original crash is a dbus-glib bug, which likely was a regression in dbus-glib 0.94 and is fixed by: http://cgit.freedesktop.org/dbus/dbus-glib/commit/?id=3e0828f57c3925ea9b63d22ab82d991a0fea0536 ie it's been fixed in db

Re: [PATCH 8/8] api: Let MM_MODEM_MODE be a bitfield, and new PreferredMode property

2011-10-05 Thread Jason Glasgow
On Mon, Oct 3, 2011 at 7:34 PM, Dan Williams wrote: > On Sat, 2011-10-01 at 15:45 +0200, Aleksander Morgado wrote: > > Hey hey, > > > > > > Supported and Allowed modes are modified to be bitmasks of > MM_MODEM_MODE values, > > > > and preference of a specific mode is now given in the new > Prefer

Re: [PATCH 2/2] Fix possible use of uninitialized variable

2011-10-05 Thread Dan Williams
On Tue, 2011-10-04 at 22:23 +0200, Thomas Jarosch wrote: > Detected by cppcheck. Applied, thanks! Dan > Signed-off-by: Thomas Jarosch > --- > src/settings/plugins/ifnet/net_utils.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/settings/plugins/ifnet/net_ut

Re: [PATCH 1/2] Use correct g_free() function

2011-10-05 Thread Dan Williams
On Tue, 2011-10-04 at 22:22 +0200, Thomas Jarosch wrote: > Detected by cppcheck. Thanks, applied. Looks like the other two variables there (var1 and var2) also need to be freed with g_free() since they are allocated using glib functions. I've added that to your patch. Dan > Signed-off-by: Thom

Re: [PATCH] support nl80211

2011-10-05 Thread Dan Williams
On Wed, 2011-10-05 at 17:40 +0200, Johannes Berg wrote: > This is on top of the nl80211 refactoring branch. Applied with some fixes, thanks! Dan > johannes > > diff --git a/src/Makefile.am b/src/Makefile.am > index aa14e8c..a225f89 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -12

[PATCH] Configure option --disable-crashtrace to disable GNU backtrace extensions.

2011-10-05 Thread David Röthlisberger
The attached patch provides a configure option to disable GNU backtrace extensions (for non-glibc toolchains). The patch is off the NM_0_8 branch, but if you like it I can work on a patch for master. 0001-Configure-option-disable-crashtrace-to-disable-GNU-b.patch Description: Binary data

[PATCH] Don't require gettext/intltool if --disable-nls configure option provided.

2011-10-05 Thread David Röthlisberger
The attached patch is so that "./configure --disable-nls" actually does what it is intended to do -- i.e. remove the dependency on intltool. The patch is off the NM_0_8 branch, but if you like it I can work on a patch for master. 0001-Don-t-require-gettext-intltool-if-disable-nls-config.patch

[PATCH] Remove dependency on PolicyKit

2011-10-05 Thread David Röthlisberger
The attached patches remove the dependency on PolicyKit by supplying a stubbed-out polkit implementation that allows every request. The change has been split into 2 patches: The first one has no functional changes, and only reorganises the code to consolidate all access to polkit headers into

[PATCH] support nl80211

2011-10-05 Thread Johannes Berg
This is on top of the nl80211 refactoring branch. johannes diff --git a/src/Makefile.am b/src/Makefile.am index aa14e8c..a225f89 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -124,6 +124,8 @@ NetworkManager_SOURCES = \ wifi-utils-private.h \ wifi-utils-wext