Re: [PATCH] core: add internet connectivity check

2011-11-22 Thread Thomas Bechtold
Hi Marcel, On 23/11/11 07:33, Marcel Holtmann wrote: However if your long term goal is WISPr support, then you have to look at the whole page anyway. There is no guarantee that the WISPr XML is at the beginning. Some providers actually just attach it to the end. personally i don't care about W

Re: [PATCH] core: add internet connectivity check

2011-11-22 Thread Marcel Holtmann
Hi Thomas, > i just want to summarize the discussion about the response handling so > we can decide which solution we want to use. > mentioned solutions are: > > 1) check http status-response 204 (or any other) (chromiumos method) > 2) check content for a specific htt

Re: device removal signals does not work for me

2011-11-22 Thread Thomas Bechtold
Hi Dan, any other idea why the example code does not work? Cheers, Tom ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: Fwd: Network manager not handling interfaces

2011-11-22 Thread Githin Alapatt
I solved part of it - I had not upgraded the kernel and the udev after dist-upgrade. I did that today and I can now control the wired device using network-manager. However, I still cannot use my wlan0. I will check on that and post my findings. Thanks for all the info! __

Re: Fwd: Network manager not handling interfaces

2011-11-22 Thread Jirka Klimes
On Friday 18 of November 2011 18:48:22 Githin Alapatt wrote: > -- Forwarded message -- > From: Githin Alapatt > Date: Thu, 17 Nov 2011 23:49:03 -0500 > Subject: Re: Network manager not handling interfaces > To: Dan Williams > > I have attached both files. TO come online, I just c

Re: [PATCH 4/8] ethernet: Move all connection <-> device matching into a single function

2011-11-22 Thread Dan Winship
On 11/22/2011 12:44 AM, Dan Williams wrote: > On Mon, 2011-11-21 at 17:50 +0100, Thomas Graf wrote: >> Moves all code to match an ethernet connection into a single function >> match_ethernet_connection() and use it from everywhere within >> NMDeviceEthernet. > > Looks good pending the outcome of t

Re: [PATCH] core: add internet connectivity check

2011-11-22 Thread Aleksander Morgado
On Tue, 2011-11-22 at 12:21 +0100, Marcel Holtmann wrote: > Actually the HTTP header makes a lot more sense since once you > received > the valid one, you can just terminate the HTTP request and do not have > to deal with downloading the whole file. You can possibly do just a HTTP HEAD request, w

Re: [PATCH] core: add internet connectivity check

2011-11-22 Thread Thomas Bechtold
Hi Marcel, On 22/11/11 12:21, Marcel Holtmann wrote: Hi Thomas, i just want to summarize the discussion about the response handling so we can decide which solution we want to use. mentioned solutions are: 1) check http status-response 204 (or any other) (chromiumos method) 2) check content fo

Re: Network manager not handling interfaces

2011-11-22 Thread Githin Alapatt
Thanks. This is what I got - lrwxrwxrwx 1 root root 0 Nov 22 07:33 /sys/class/net/eth0/device/driver -> ../../../../bus/pci/drivers/sky2 This is what I got. I remember seeing elsewhere that sky2 was my eth0 driver. I did not build the kernel myself.It is a standard kernel. And, I am not sure if

Re: [PATCH] core: add internet connectivity check

2011-11-22 Thread Marcel Holtmann
Hi Thomas, > >> i just want to summarize the discussion about the response handling so > >> we can decide which solution we want to use. > >> mentioned solutions are: > >> > >> 1) check http status-response 204 (or any other) (chromiumos method) > >> 2) check content for a specific http header (co

[PATCH 6/7] bonding: Log slave activation/deactivation

2011-11-22 Thread Thomas Graf
Signed-off-by: Thomas Graf --- src/nm-device.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/nm-device.c b/src/nm-device.c index 5721f73..40e03bb 100644 --- a/src/nm-device.c +++ b/src/nm-device.c @@ -793,6 +793,11 @@ handle_slave_activation (NMDevice *sla

[PATCH 7/7] bonding: Move bonding master state to UNAVAILABLE regardless of carrier state

2011-11-22 Thread Thomas Graf
The carrier of a bonding device is the sum of the carrier state of all its slaves. The carrier is always off if no slaves have been attached to the master yet. Therefore the carrier state is of no interest when making a bonding connection available but we still want to use carrier detection to mov

[PATCH 5/7] cli: Move ethernet connection matching to libnm-glib and add bonding support

2011-11-22 Thread Thomas Graf
Move the code to match an ethernet device with a connection to libnm-glib and support bonding connections. Signed-off-by: Thomas Graf --- cli/src/connections.c | 60 +- libnm-glib/libnm-glib.ver |1 + libnm-glib/nm-device-ethernet.c | 6

[PATCH 4/7] ethernet: Allow devices to be reassumed when ip4 config is disabled

2011-11-22 Thread Thomas Graf
Ethernet connections acting as bonding slave will have their ip4 config disabled. Allow such connections to reassume devices. Signed-off-by: Thomas Graf --- src/nm-device-ethernet.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/nm-device-ethernet.c b/src/nm-dev

[PATCH 3/7] ethernet: Move all connection <-> device matching into a single function

2011-11-22 Thread Thomas Graf
Moves all code to match an ethernet connection into a single function match_ethernet_connection() and use it from everywhere within NMDeviceEthernet. Signed-off-by: Thomas Graf --- src/nm-device-ethernet.c | 267 +- 1 files changed, 97 insertions(+),

[PATCH 2/7] ethernet: Check kernel interface binding when matching config

2011-11-22 Thread Thomas Graf
When matching an ethernet device with connection settings, check if the connection needs to be bound to a specific virtual kernel interface. Signed-off-by: Thomas Graf --- src/nm-device-ethernet.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/nm-device-ethernet

[PATCH 1/7] bonding: Add nm_connection_get_virtual_iface_name() to abstract kernel interface binding

2011-11-22 Thread Thomas Graf
Some connection types such as bonding, bridging and VLAN require specific virtual kernel interfaces identified by name to be auto connected to the connection. The function nm_connection_get_virtual_iface_name() returns the name of the kernel interface if the connection type requires this functiona

[PATCH 0/7] bonding updates v2

2011-11-22 Thread Thomas Graf
Revised set of bonding updates with Dan's comments addressed. This is currently based on top of the cleanup patches I have posted yesterday. The main focus is on getting the connection to device matching right to correctly reassume devices and allow manipulating bonding connections via the CLI. I

Re: [PATCH] core: add internet connectivity check

2011-11-22 Thread Thomas Bechtold
Hi Marcel, On 22/11/11 08:55, Marcel Holtmann wrote: Hi Thomas, i just want to summarize the discussion about the response handling so we can decide which solution we want to use. mentioned solutions are: 1) check http status-response 204 (or any other) (chromiumos method) 2) check content fo

Re: [PATCH 2/8] bonding: Add nm_connection_get_iface_name() to abstract kernel interface binding

2011-11-22 Thread Thomas Graf
On Mon, 2011-11-21 at 18:24 -0600, Dan Williams wrote: > > @@ -909,12 +893,9 @@ real_get_best_auto_connection (NMDevice *dev, > > > > connection_type = nm_setting_connection_get_connection_type > > (s_con); > > > > - if (!strcmp (connection_type, NM_SETTING_BOND_SETTING_

Re: [PATCH 4/8] ethernet: Move all connection <-> device matching into a single function

2011-11-22 Thread Thomas Graf
On Mon, 2011-11-21 at 23:44 -0600, Dan Williams wrote: > On Mon, 2011-11-21 at 17:50 +0100, Thomas Graf wrote: > > Moves all code to match an ethernet connection into a single function > > match_ethernet_connection() and use it from everywhere within > > NMDeviceEthernet. > > Looks good pending th

Re: [PATCH 8/8] bonding: Move bonding master state to UNAVAILABLE regardless of carrier state

2011-11-22 Thread Thomas Graf
On Mon, 2011-11-21 at 23:40 -0600, Dan Williams wrote: > > > + if (!strcmp(nm_device_get_driver (self), "bonding")) > > + priv->type = NM_ETHERNET_TYPE_BOND; > > + else > > + priv->type = NM_ETHERNET_TYPE_UNSPEC; > > That part is somewhat icky; we could create a new priva

Re: [PATCH 2/8] bonding: Add nm_connection_get_iface_name() to abstract kernel interface binding

2011-11-22 Thread Thomas Graf
On Mon, 2011-11-21 at 18:24 -0600, Dan Williams wrote: > Would you mind renaming this to nm_connection_get_virtual_iface_name() > instead? To make it clear that this interface name is only used for > virtual interfaces and is not relevant for base types that have backing > hardware. > Also the id