Re: [MM] [PATCH] port-probe: fix crash in serial_probe_at_parse_response due to NULL response

2012-07-11 Thread Aleksander Morgado
> When the serial port is not open, internal_queue_command > (mm-serial-port.c) invokes serial_probe_at_parse_response > (mm-port-probe.c) with a NULL response. This patch modifies > serial_probe_at_parse_response to handle that properly. > --- > src/mm-port-probe.c |2 +- > 1 files changed,

Re: [MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Aleksander Morgado
Hey Ben, > > Yep, that works too. How about this? > > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index 49a18a5..7b44d6a 100644 > --- a/src/mm-iface-modem.c > +++ b/src/mm-iface-modem.c > @@ -3676,6 +3676,14 @@ mm_iface_modem_shutdown (MMIfaceModem *self) > { > g_return_if_

[MM] [PATCH] port-probe: fix crash in serial_probe_at_parse_response due to NULL response

2012-07-11 Thread Ben Chan
When the serial port is not open, internal_queue_command (mm-serial-port.c) invokes serial_probe_at_parse_response (mm-port-probe.c) with a NULL response. This patch modifies serial_probe_at_parse_response to handle that properly. --- src/mm-port-probe.c |2 +- 1 files changed, 1 insertions(+)

[MM] [PATCH v2] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Ben Chan
expire_signal_quality() may be called after the DBus object skeleton is removed in mm_iface_modem_shutdown() and before signal_quality_update_context_free() is called due to the destruction of the modem object. This patch fixes the issue by canceling any pending invocation of expire_signal_quality(

Re: [MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Ben Chan
Hi Aleksander, Yep, that works too. How about this? diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index 49a18a5..7b44d6a 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -3676,6 +3676,14 @@ mm_iface_modem_shutdown (MMIfaceModem *self) { g_return_if_fail (MM_IS_IFA

Re: [MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Aleksander Morgado
Hey Ben, > expire_signal_quality() may be called after the DBus object skeleton is > removed in mm_iface_modem_shutdown() and before > signal_quality_update_context_free() is called due to the destruction of > the modem object. This patch prevents expire_signal_quality() from > accessing an alread

[MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Ben Chan
expire_signal_quality() may be called after the DBus object skeleton is removed in mm_iface_modem_shutdown() and before signal_quality_update_context_free() is called due to the destruction of the modem object. This patch prevents expire_signal_quality() from accessing an already removed skeleton.

Building network-manager-applet

2012-07-11 Thread Miguel Guedes
Hi All, I'm trying to build network-manager-applet on Xubuntu 12.04 and was wondering if it is possible to (and if so, how) build from the latest git version and *not* off -devel packages. Autotools uses pkg-config which restricts me to using devel packages; how do I override this behaviour s

Re: Modem-manager logging levels

2012-07-11 Thread binro
Aleksander Morgado-5 wrote: > >> >> How do I get NM to start modem-manager with "--log-level=WARN"? > You'll need to avoid having NM do the dbus-activated start. You can > avoid this by moving the modem-manager binary from > /usr/sbin/modem-manager to another location, like /modem-manager. Once