Re: [PATCH 1/2] modem-manager: keep track of the signals added to the 'GDBusObjectManagerClient'

2013-02-07 Thread Aleksander Morgado
On 08/02/13 08:32, Aleksander Morgado wrote: > Make sure we cleanup all the signals when we remove our internal reference to > the 'MMManager' object. > --- > src/modem-manager/nm-modem-manager.c | 64 > > 1 file changed, 51 insertions(+), 13 deletions(-) Ple

[PATCH v2 2/2] modem-manager: workaround issue in 'GDBusObjectManagerClient'

2013-02-07 Thread Aleksander Morgado
The 'GDBusObjectManagerClient' won't signal added or removed objects when it was created but no name owner was available in the bus. We can still use it for name-owner changes, but in order to have added/removed object signals, we'll need to re-create the whole 'MMManager' when we know the service

[PATCH v2 1/2] modem-manager: keep track of the signals added to the 'GDBusObjectManagerClient'

2013-02-07 Thread Aleksander Morgado
Make sure we cleanup all the signals when we remove our internal reference to the 'MMManager' object. --- src/modem-manager/nm-modem-manager.c | 64 1 file changed, 51 insertions(+), 13 deletions(-) diff --git a/src/modem-manager/nm-modem-manager.c b/src/mode

[PATCH 2/2] modem-manager: workaround issue in 'GDBusObjectManagerClient'

2013-02-07 Thread Aleksander Morgado
The 'GDBusObjectManagerClient' won't signal added or removed objects when it was created but no name owner was available in the bus. We can still use it for name-owner changes, but in order to have added/removed object signals, we'll need to re-create the whole 'MMManager' when we know the service

[PATCH 1/2] modem-manager: keep track of the signals added to the 'GDBusObjectManagerClient'

2013-02-07 Thread Aleksander Morgado
Make sure we cleanup all the signals when we remove our internal reference to the 'MMManager' object. --- src/modem-manager/nm-modem-manager.c | 64 1 file changed, 51 insertions(+), 13 deletions(-) diff --git a/src/modem-manager/nm-modem-manager.c b/src/mode

Re: [PATCH] modem-manager: properly follow name-owner changes

2013-02-07 Thread Dan Williams
On Thu, 2013-02-07 at 16:47 +0100, Aleksander Morgado wrote: > We avoid requesting to auto-start the service when the 'MMManager' is created, > so that we can use it to follow name-owner changes (when auto-starting > requested the 'MMManager' creation may fail). > > We still handle the periodic po

[PATCH] modem-manager: properly follow name-owner changes

2013-02-07 Thread Aleksander Morgado
We avoid requesting to auto-start the service when the 'MMManager' is created, so that we can use it to follow name-owner changes (when auto-starting requested the 'MMManager' creation may fail). We still handle the periodic poking to the service, but instead of re-creating the 'MMManager', we jus