On 02/28/2013 08:11 PM, Ben Chan wrote:
> ---
> src/mm-iface-modem-3gpp.c | 15 +++
> 1 file changed, 15 insertions(+)
>
I pushed it after modifying it to include the
clear_deferred_registration_state_update() call in the first
DISABLING_STEP_PERIODIC_REGISTRATION_CHECKS step. As sai
> -Original Message-
> From: networkmanager-list [mailto:networkmanager-list-
> boun...@gnome.org] On Behalf Of Dan Williams
> Sent: Thursday, February 28, 2013 11:09 AM
> To: Aleksander Morgado
> Cc: networkmanager-list@gnome.org
> Subject: Re: [MM] [PATCH v3] serial: Add support to option
---
src/mm-iface-modem-3gpp.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c
index fa8da1a..2430056 100644
--- a/src/mm-iface-modem-3gpp.c
+++ b/src/mm-iface-modem-3gpp.c
@@ -1325,6 +1325,18 @@ periodic_registration_check_
On Thu, 2013-02-28 at 17:59 +0100, Dan Williams wrote:
> On Thu, 2013-02-28 at 16:34 +0100, Aleksander Morgado wrote:
> > On 02/28/2013 03:20 PM, Dan Williams wrote:
> > >> > Also, are you going to suggest a new plugin for MM using this property
> > >> > set to TRUE? If so, it may be a good idea to
On Thu, 2013-02-28 at 16:34 +0100, Aleksander Morgado wrote:
> On 02/28/2013 03:20 PM, Dan Williams wrote:
> >> > Also, are you going to suggest a new plugin for MM using this property
> >> > set to TRUE? If so, it may be a good idea to send all relevant commits,
> >> > including this one, in the s
On 02/28/2013 03:20 PM, Dan Williams wrote:
>> > Also, are you going to suggest a new plugin for MM using this property
>> > set to TRUE? If so, it may be a good idea to send all relevant commits,
>> > including this one, in the same patch series, along with the plugin.
> Now that I think about it,
On Thu, 2013-02-28 at 09:38 +0100, Aleksander Morgado wrote:
> On 02/28/2013 09:24 AM, ori.in...@altair-semi.com wrote:
> > From: ori inbar
> >
>
> Looks good; some minor comments below.
>
> Also, are you going to suggest a new plugin for MM using this property
> set to TRUE? If so, it may be a
From: ori inbar
Change-Id: Id2df103232174d7a2b8575aaf04ed196e7a901d5
---
src/mm-at-serial-port.c | 34 +++---
src/mm-at-serial-port.h |2 ++
src/mm-plugin.c | 19 +++
src/mm-plugin.h |1 +
src/mm-port-probe.c |5
To support modems that require a line-feed at the end of AT commands sent
for example altair-lte modem.
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list
From: ori inbar
Change-Id: Id2df103232174d7a2b8575aaf04ed196e7a901d5
---
src/mm-at-serial-port.c | 34 +++---
src/mm-at-serial-port.h |2 ++
src/mm-plugin.c | 19 +++
src/mm-plugin.h |1 +
src/mm-port-probe.c |5
To support modems that require a line-feed at the end of AT commands sent
for example altair-lte modem.
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list
>>
>> When I reviewed your original patch I actually checked for when we were
>> removing the timeout when disabling, and assumed it was done when we set
>> the GObject's data to NULL, but I mixed the two data objects we handle
>> here, as one of them (the one where this new timeout id is stored)
One question inline
On Feb 28, 2013 12:23 AM, "Aleksander Morgado"
wrote:
>
> On 02/27/2013 11:04 PM, Ben Chan wrote:
> > ---
> > src/mm-iface-modem-3gpp.c | 18 +-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
>
> When I reviewed your original patch I actually checked for
On Thu, 2013-02-28 at 04:57 -0500, Pavel Simerda wrote:
> Hi all,
>
> I would like to do *occasional* C99-style declarations in the code to avoid
> ugly hacks when using conditionally built code. That means bumping up the
> compiler requirements to the C99 standard. As we currently only target t
Hi all,
I would like to do *occasional* C99-style declarations in the code to avoid
ugly hacks when using conditionally built code. That means bumping up the
compiler requirements to the C99 standard. As we currently only target to GCC
and possibly LLVM, I don't think it would be a problem.
I
On 02/28/2013 09:24 AM, ori.in...@altair-semi.com wrote:
> From: ori inbar
>
Looks good; some minor comments below.
Also, are you going to suggest a new plugin for MM using this property
set to TRUE? If so, it may be a good idea to send all relevant commits,
including this one, in the same patc
From: ori inbar
---
src/mm-at-serial-port.c | 34 +++---
src/mm-at-serial-port.h |2 ++
src/mm-plugin.c | 19 +++
src/mm-plugin.h |1 +
src/mm-port-probe.c |5 +
src/mm-port-probe.h |1 +
6 files changed,
On 02/27/2013 11:04 PM, Ben Chan wrote:
> ---
> src/mm-iface-modem-3gpp.c | 18 +-
> 1 file changed, 17 insertions(+), 1 deletion(-)
When I reviewed your original patch I actually checked for when we were
removing the timeout when disabling, and assumed it was done when we set
the
18 matches
Mail list logo
