Re: [MM][PATCH] remove comparison of unsigned expression = 0

2013-04-29 Thread Aleksander Morgado
On 27/04/13 07:29, Yunlian Jiang wrote: This patch removes a few unnecessary checks of unsigned expression = 0, which also fixes the following clang warnings: Patch doesn't seem to be cleanly applicable with git am. How did you create it? Please use either git send-email or git format-patch.

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-29 Thread Aleksander Morgado
On 27/04/13 07:21, Yunlian Jiang wrote: This patch fixes mismatched enum type for a function parameter, which fixes the following clang warning: Patch doesn't seem to be cleanly applicable with git am. How did you create it? Please use either git send-email or git format-patch.

Re: periodic network disconnects (reason 'ip-config-unavailable')

2013-04-29 Thread Dan Williams
On Sat, 2013-04-27 at 13:56 -0400, Chuck Anderson wrote: On Fedora 18, I'm seeing periodic network disconnects with these messages in the log: Apr 27 11:01:11 a NetworkManager[833]: info (wlan0): device state change: activated - failed (reason 'ip-config-unavailable') [100 120 5] Apr 27

Re: right-click

2013-04-29 Thread Dan Williams
On Sun, 2013-04-28 at 17:54 -0700, Chris Hellberg wrote: Hi, In the main dialog screen with the list of connections, on the left there is the list of connections and the bottom right, a configure button. However there are no right-click options on each connection (ie as a

Re: [MM][PATCH] remove comparison of unsigned expression = 0

2013-04-29 Thread Ben Chan
How about the cid case? cid == 0 seems to be an invalid value? On Apr 28, 2013 10:55 PM, Aleksander Morgado aleksan...@lanedo.com wrote: On 27/04/13 08:00, Ben Chan wrote: [Ben] Aleksander, do you think the original code was meant to check quality 0? +if (!max) { /*

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-29 Thread Yunlian Jiang
Please try this one from git format-patch Thanks --- libmm-glib/mm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c index 46dd8ce..efea9b0 100644 --- a/libmm-glib/mm-manager.c +++ b/libmm-glib/mm-manager.c @@ -93,7

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-29 Thread Yunlian Jiang
--- libmm-glib/mm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c index 46dd8ce..efea9b0 100644 --- a/libmm-glib/mm-manager.c +++ b/libmm-glib/mm-manager.c @@ -93,7 +93,7 @@ ensure_modem_manager1_proxy (MMManager

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-29 Thread Dan Williams
On Mon, 2013-04-29 at 09:35 -0700, Yunlian Jiang wrote: --- libmm-glib/mm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Unfortunately this one doesn't work either, because your email client line-wrapped it, so we get: Applying: mm-glib: use correct enum type fatal: corrupt

Re: right-click

2013-04-29 Thread Chris Hellberg
What would on and off do?  Also, is this nm-connection-editor or the KDE editor or the GNOME control center network pane something else? Thanks, Dan on and off would correspond to the on/off toggle switch on the top right of the nm-connection-editor. Cheers, Chris

Re: Any volunteers for becoming a GSoC co-mentor for proxy integration project?

2013-04-29 Thread Hedayat Vatankhah
/*Dan Williams d...@redhat.com*/ wrote on Fri, 26 Apr 2013 13:52:02 -0500: On Fri, 2013-04-26 at 14:24 -0400, Pavel Simerda wrote: - Original Message - From: Dan Williams d...@redhat.com To: Hedayat Vatankhah heday...@gmail.com Cc: networkmanager-list@gnome.org Sent: Friday, April