Wed, Aug 21, 2013 at 06:08:19PM CEST, d...@gnome.org wrote:
You should add a test case to test-ifcfg-rh for this, to make sure we
don't break it later.
Will try.
Other than that, just nitpicks:
Drop the word do in the commit summary line.
+static gchar *get_numbered_tag (gchar *tag_name,
v1-v2:
- Processed DanW's comments
- added test case
Jiri Pirko (2):
ifcfg-rh: reader: allow device to not have ipv4 setting.
ifcfg-rh: add test for BOOTPROTO=none reader
libnm-util/nm-setting-ip4-config.c | 27 --
libnm-util/nm-setting-ip6-config.c |
Signed-off-by: Jiri Pirko j...@resnulli.us
---
.../ifcfg-rh/tests/network-scripts/ifcfg-test-noip | 3 ++
.../plugins/ifcfg-rh/tests/test-ifcfg-rh.c | 47 ++
2 files changed, 50 insertions(+)
create mode 100644
If BOOTPROTO is set to none, user states that no ipv4 setting should
be set. So respect that.
Introduce helper is_any_ip4_address_defined() along the way to make the
code more readable.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
libnm-util/nm-setting-ip4-config.c | 27 -
On 08/22/2013 03:44 AM, Jiri Pirko wrote:
Should be split onto two lines. Also, we don't generally use gchar
(just use char), and there's no particular reason to use gint32 rather
than int here. (I see that there are some existing gint32s in that
file... I have no idea why.)
With this I
On 08/22/2013 08:17 AM, Jiri Pirko wrote:
v1-v2:
- Processed DanW's comments
- added test case
Thanks. Committed.
(And you should request NM git access.
https://bugs.freedesktop.org/enter_bug.cgi?product=freedesktop.org,
component New Accounts or Account Modification Requests depending on
I committed the non-nmcli parts (with three small fixes: added spaces
before ( in function calls [eg, teamdctl_alloc ()], fixed a build
error when building without libteamdctl [error: unused variable
'priv'], and made a minor grammatical tweak to a log message).
I'll leave the nmcli bits for
Thu, Aug 22, 2013 at 03:47:24PM CEST, d...@gnome.org wrote:
I committed the non-nmcli parts (with three small fixes: added spaces
before ( in function calls [eg, teamdctl_alloc ()], fixed a build
error when building without libteamdctl [error: unused variable
'priv'], and made a minor grammatical
* Nicolas Iooss
A few weeks ago I ran into a bug in NetworkManager: even though OpenVPN
now supports IPv6 in tunnels, the OpenVPN plugin of NetworkManager
doesn't support it. I found bug 682620
(https://bugzilla.gnome.org/show_bug.cgi?id=682620) and I've implemented
some of the missing
2013/8/21 Dan Winship
On 08/19/2013 12:47 PM, Nicolas Iooss wrote:
The patches are working well in my testing environment with
NetworkManager 0.9.8 but with the development revision I've got few
issues such as https://bugzilla.gnome.org/show_bug.cgi?id=706286. Now NM
crashes on a
Thanks for testing my patches!
I noticed that the default route also gets redirected to the tunnel
device even though the server does not push this route. So internet
connectivity is broken unless I explicitly enable the use this
connection for resources on its network setting. However I
11 matches
Mail list logo
