[PATCH] device: increase object ref count before invoking g_idle_add

2016-05-04 Thread Shih-Yuan Lee (FourDollars)
--- src/devices/nm-device.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index ad6f835..77f8874 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -1990,8 +1990,8 @@ realize_start

[PATCH] device: increase object ref count before invoking g_idle_add

2016-05-04 Thread Shih-Yuan Lee (FourDollars)
There are three different crash cases during the suspend&resume stress test. Inreasing the object reference count before invoking g_idle_add() can avoid this kind of race condition. === crash #1 === GNU gdb (Ubuntu 7.11-0ubuntu1) 7.11 Copyright (C) 2016 Free Software Foundation, Inc. License GPLv

[PATCH] libnm: Check the priv pointer before loop traverse.

2016-05-04 Thread Shih-Yuan Lee (FourDollars)
--- libnm/nm-manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libnm/nm-manager.c b/libnm/nm-manager.c index a6c1f3f..9316fdb 100644 --- a/libnm/nm-manager.c +++ b/libnm/nm-manager.c @@ -816,6 +816,8 @@ recheck_pending_activations (NMManager *self) const GPtrArray *devices;

[PATCH] libnm: Check the priv pointer before loop traverse.

2016-05-04 Thread Shih-Yuan Lee (FourDollars)
When we used WWAN and enabled the PIN on SIM, we encountered the following crash during the stress suspend&resume test. This patch can avoid this crash. GNU gdb (Ubuntu 7.11-0ubuntu1) 7.11 Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later