[PATCH] device: Remove unnecessary object reference operations

Since commit 0175056a6d70bafdaf1042eb8f5e1ef57484a3f2, it is unnecessary to operate object reference when invoking g_idle_add so it is unnecessary to operate object reference in GSourceFunc too. --- src/devices/nm-device.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH] device: increase object ref count before invoking g_idle_add

On Wed, 2016-05-04 at 17:27 +0800, Shih-Yuan Lee (FourDollars) wrote: > --- >  src/devices/nm-device.c | 25 + >  1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c > index ad6f835..77f8874 100644 > ---

Re: [PATCH] libnm: Check the priv pointer before loop traverse.

On Thu, May 5, 2016 at 4:33 PM, Thomas Haller wrote: > On Wed, 2016-05-04 at 16:09 +0800, Shih-Yuan Lee (FourDollars) wrote: > > When we used WWAN and enabled the PIN on SIM, we encountered the > > following > > crash during the stress suspend test. > > > > This patch can

Re: [PATCH] libnm: Check the priv pointer before loop traverse.

On Wed, 2016-05-04 at 16:09 +0800, Shih-Yuan Lee (FourDollars) wrote: > When we used WWAN and enabled the PIN on SIM, we encountered the > following > crash during the stress suspend test. > > This patch can avoid this crash. > > GNU gdb (Ubuntu 7.11-0ubuntu1) 7.11 > Copyright (C) 2016 Free

Re: [PATCH] libnm: Check the priv pointer before loop traverse.

I see. Thx for your review. On Thu, May 5, 2016 at 4:11 PM, Thomas Haller wrote: > On Wed, 2016-05-04 at 16:09 +0800, Shih-Yuan Lee (FourDollars) wrote: > > --- > > libnm/nm-manager.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libnm/nm-manager.c

Re: [PATCH] libnm: Check the priv pointer before loop traverse.

On Wed, 2016-05-04 at 16:09 +0800, Shih-Yuan Lee (FourDollars) wrote: > --- >  libnm/nm-manager.c | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/libnm/nm-manager.c b/libnm/nm-manager.c > index a6c1f3f..9316fdb 100644 > --- a/libnm/nm-manager.c > +++ b/libnm/nm-manager.c > @@ -816,6