Re: [PATCH] device: Remove unnecessary object reference operations

2016-05-06 Thread Thomas Haller
On Fri, 2016-05-06 at 13:46 +0800, Shih-Yuan Lee (FourDollars) wrote: > Since commit 0175056a6d70bafdaf1042eb8f5e1ef57484a3f2, it is > unnecessary > to operate object reference when invoking g_idle_add so it is > unnecessary to operate object reference in GSourceFunc too. > --- Hi, Patch applied

Re: [PATCH] libnm: Warning if private data is NULL

2016-05-06 Thread Thomas Haller
On Fri, 2016-05-06 at 14:01 +0800, Shih-Yuan Lee (FourDollars) wrote: > Check the priv pointer before loop traverse. > Warning this instead of leaving the program crash directly. > --- >  libnm/nm-manager.c | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/libnm/nm-manager.c b/libnm/nm