Hi,
On Tue, 2019-02-26 at 14:56 +0800, Gris Ge via networkmanager-list
> "protocol": "dhcp", # "static" or "dhcp"
"protocol" sounds a bit like iproute2's "protocol" option (struct
rtmsg's rtm_protocol). But I think it's not.
I would call this "source".
best,
Thomas
On Thu, 2019-02-28 at 22:40 +0200, Edward Haas via networkmanager-list
wrote:
> Thank you Gris.
> Comments in-line.
>
> On Tue, Feb 26, 2019 at 8:56 AM Gris Ge wrote:
> > Hi Guys,
> >
> > Could you review below schema for routing in nmstate before we
> > start
> > add routing support in
On Fri, Mar 1, 2019 at 4:34 AM Gris Ge wrote:
> On Thu, Feb 28, 2019 at 10:40:48PM +0200, Edward Haas wrote:
> >
> > What is the root level key? `routing`?
> The root level is 'ipv4-routes' and 'ipv6-routes'.
>
> Try to save a layer for user to type comparing to ['routing']['routes']
>
> The ip
On Thu, Feb 28, 2019 at 10:40:48PM +0200, Edward Haas wrote:
>
> What is the root level key? `routing`?
The root level is 'ipv4-routes' and 'ipv6-routes'.
Try to save a layer for user to type comparing to ['routing']['routes']
> ipv4 and ipv6 look identical to me here.
> It makes sense then to
Thank you Gris.
Comments in-line.
On Tue, Feb 26, 2019 at 8:56 AM Gris Ge wrote:
> Hi Guys,
>
> Could you review below schema for routing in nmstate before we start
> add routing support in nmstate?
>
> ```
>
What is the root level key? `routing`?
{
> "ipv4-routes": [# Sorted
