[PATCH] linux: check the prefix 'wlan' for WiFi device as the last fallback

https://bugzilla.gnome.org/show_bug.cgi?id=767317 Signed-off-by: Shih-Yuan Lee (FourDollars) <sy...@canonical.com> --- src/platform/wifi/wifi-utils.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/platform/wifi/wifi-utils.c b/src/platform/wifi/wifi-utils.c index d

[PATCH] linux: check the prefix 'wlan' for WiFi device as the last fallback method

wlan0/dev_id: Failed to open file '/sys/class/net/wlan0/dev_id': No such file or directory After the device type is decided as NM_LINK_TYPE_ETHERNET, there is no way back unless NetworkManager will check all device types again, but it won't do that. Shih-Yuan Lee (FourDollars) (1): linux: check the

[PATCH] libnm: Warning if private data is NULL

Check the priv pointer before loop traverse. Warning this instead of leaving the program crash directly. --- libnm/nm-manager.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libnm/nm-manager.c b/libnm/nm-manager.c index a6c1f3f..7d86a51 100644 --- a/libnm/nm-manager.c +++

[PATCH] device: Remove unnecessary object reference operations

Since commit 0175056a6d70bafdaf1042eb8f5e1ef57484a3f2, it is unnecessary to operate object reference when invoking g_idle_add so it is unnecessary to operate object reference in GSourceFunc too. --- src/devices/nm-device.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH] libnm: Check the priv pointer before loop traverse.

On Thu, May 5, 2016 at 4:33 PM, Thomas Haller <thal...@redhat.com> wrote: > On Wed, 2016-05-04 at 16:09 +0800, Shih-Yuan Lee (FourDollars) wrote: > > When we used WWAN and enabled the PIN on SIM, we encountered the > > following > > crash during the stress suspend t

Re: [PATCH] libnm: Check the priv pointer before loop traverse.

I see. Thx for your review. On Thu, May 5, 2016 at 4:11 PM, Thomas Haller <thal...@redhat.com> wrote: > On Wed, 2016-05-04 at 16:09 +0800, Shih-Yuan Lee (FourDollars) wrote: > > --- > > libnm/nm-manager.c | 2 ++ > > 1 file changed, 2 insertions(+) > > >

[PATCH] device: increase object ref count before invoking g_idle_add

--- src/devices/nm-device.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index ad6f835..77f8874 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -1990,8 +1990,8 @@

[PATCH] device: increase object ref count before invoking g_idle_add

mov%rdi,%rbx 0x004777e4 <+4>: callq 0x45fae0 0x004777e9 <+9>: mov%rbx,%rdi 0x004777ec <+12>:mov%rax,%rsi 0x004777ef <+15>:callq 0x43fc60 <g_type_check_instance_

[PATCH] libnm: Check the priv pointer before loop traverse.

--- libnm/nm-manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libnm/nm-manager.c b/libnm/nm-manager.c index a6c1f3f..9316fdb 100644 --- a/libnm/nm-manager.c +++ b/libnm/nm-manager.c @@ -816,6 +816,8 @@ recheck_pending_activations (NMManager *self) const GPtrArray *devices;

[PATCH] libnm: Check the priv pointer before loop traverse.

ter = iter->next) { 825 NMDevice *dev = iter->data; 826 827 if (nm_device_has_pending_action (dev)) { 828 _LOGD (LOGD_CORE, "check_if_startup_complete returns FALSE because of %s", (gdb) print priv $1 = (NMM