Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-30 Thread Dan Williams
On Tue, 2013-04-30 at 11:33 -0700, Yunlian Jiang wrote: > Hi Dan, >I did not see it in the tree. >Here is the updated patch without line wrapp. It's git commit 9dcbf33c88615b6b3baeec0d79a320b6df0bd403. And unfortunately the patch here is still linewrapped... usually the mail client has s

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-30 Thread Yunlian Jiang
Hi Dan, I did not see it in the tree. Here is the updated patch without line wrapp. Thanks, --- libmm-glib/mm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c index 46dd8ce..efea9b0 100644 --- a/libmm-glib/mm-

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-29 Thread Dan Williams
On Mon, 2013-04-29 at 09:35 -0700, Yunlian Jiang wrote: > --- > libmm-glib/mm-manager.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Unfortunately this one doesn't work either, because your email client line-wrapped it, so we get: Applying: mm-glib: use correct enum type fatal: corrup

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-29 Thread Yunlian Jiang
--- libmm-glib/mm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c index 46dd8ce..efea9b0 100644 --- a/libmm-glib/mm-manager.c +++ b/libmm-glib/mm-manager.c @@ -93,7 +93,7 @@ ensure_modem_manager1_proxy (MMManager *sel

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-29 Thread Yunlian Jiang
Please try this one from git format-patch Thanks --- libmm-glib/mm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c index 46dd8ce..efea9b0 100644 --- a/libmm-glib/mm-manager.c +++ b/libmm-glib/mm-manager.c @@ -93,7 +93

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-28 Thread Aleksander Morgado
On 27/04/13 07:21, Yunlian Jiang wrote: > This patch fixes mismatched enum type for a function parameter, which > fixes the following clang warning: Patch doesn't seem to be cleanly applicable with "git am". How did you create it? Please use either git send-email or git format-patch. > > mm-mana

[MM][PATCH] mm-glib: use correct enum type

2013-04-26 Thread Yunlian Jiang
This patch fixes mismatched enum type for a function parameter, which fixes the following clang warning: mm-manager.c:112:65: error: implicit conversion from enumeration type 'GDBusObjectManagerClientFlags' to different enumeration type 'GDBusProxyFlags' [-Werror,-Wenum-conversion]