Re: [MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-12 Thread Ben Chan
I revised the patch to clean up some more context objects in mm-modem-iface. Thanks. On Wed, Jul 11, 2012 at 11:48 PM, Aleksander Morgado wrote: > Hey Ben, > > > > > Yep, that works too. How about this? > > > > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > > index 49a18a5..7b44d6a

Re: [MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Aleksander Morgado
Hey Ben, > > Yep, that works too. How about this? > > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > index 49a18a5..7b44d6a 100644 > --- a/src/mm-iface-modem.c > +++ b/src/mm-iface-modem.c > @@ -3676,6 +3676,14 @@ mm_iface_modem_shutdown (MMIfaceModem *self) > { > g_return_if_

Re: [MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Ben Chan
Hi Aleksander, Yep, that works too. How about this? diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c index 49a18a5..7b44d6a 100644 --- a/src/mm-iface-modem.c +++ b/src/mm-iface-modem.c @@ -3676,6 +3676,14 @@ mm_iface_modem_shutdown (MMIfaceModem *self) { g_return_if_fail (MM_IS_IFA

Re: [MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Aleksander Morgado
Hey Ben, > expire_signal_quality() may be called after the DBus object skeleton is > removed in mm_iface_modem_shutdown() and before > signal_quality_update_context_free() is called due to the destruction of > the modem object. This patch prevents expire_signal_quality() from > accessing an alread

[MM] [PATCH] iface-modem: Fix crash in expire_signal_quality due to removed skeleton.

2012-07-11 Thread Ben Chan
expire_signal_quality() may be called after the DBus object skeleton is removed in mm_iface_modem_shutdown() and before signal_quality_update_context_free() is called due to the destruction of the modem object. This patch prevents expire_signal_quality() from accessing an already removed skeleton.