Re: [OT] Re: [MM] [PATCH v2] iface-modem, novatel-lte: disable network scan in LTE mode

2013-01-04 Thread Aleksander Morgado
> >> You cannot mix in the same async method a code execution path using >> mm_base_modem_at_command() with another one using GSimpleAsyncResult and >> completion in idle. When you use mm_base_modem_at_command(), in >> finish() you're expected to use mm_base_modem_at_command_finish(), like >> yo

[OT] Re: [MM] [PATCH v2] iface-modem,novatel-lte: disable network scan in LTE mode

2013-01-04 Thread Marius Kotsbak
On Jan 4, 2013 12:58 AM, "Aleksander Morgado" wrote: > You cannot mix in the same async method a code execution path using > mm_base_modem_at_command() with another one using GSimpleAsyncResult and > completion in idle. When you use mm_base_modem_at_command(), in > finish() you're expected to us

Re: [MM] [PATCH v2] iface-modem, novatel-lte: disable network scan in LTE mode

2013-01-03 Thread Ben Chan
Thanks for the notes. Submitted patch v3. - Ben On Thu, Jan 3, 2013 at 3:58 PM, Aleksander Morgado wrote: > > > +static GList * > > +scan_networks_finish (MMIfaceModem3gpp *self, > > + GAsyncResult *res, > > + GError **error) > > +{ > > +const gcha

Re: [MM] [PATCH v2] iface-modem,novatel-lte: disable network scan in LTE mode

2013-01-03 Thread Aleksander Morgado
> +static GList * > +scan_networks_finish (MMIfaceModem3gpp *self, > + GAsyncResult *res, > + GError **error) > +{ > +const gchar *result; > + > +result = mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, > error); > +if (!result) >

[MM] [PATCH v2] iface-modem, novatel-lte: disable network scan in LTE mode

2013-01-03 Thread Ben Chan
--- plugins/novatel/mm-broadband-modem-novatel-lte.c | 72 +- src/mm-iface-modem.c | 20 ++ src/mm-iface-modem.h |3 + 3 files changed, 94 insertions(+), 1 deletions(-) diff --git a/plugins/novatel/mm-broadban