Re: [MM] [PATCH v3] serial: Add support to optionally send line-feed at the end of AT commands.

2013-03-03 Thread Dan Williams
do > > Cc: networkmanager-list@gnome.org > > Subject: Re: [MM] [PATCH v3] serial: Add support to optionally send > > line-feed > > at the end of AT commands. > > > > On Thu, 2013-02-28 at 17:59 +0100, Dan Williams wrote: > > > On Thu, 2013-02-28 at 16:34 +0

RE: [MM] [PATCH v3] serial: Add support to optionally send line-feed at the end of AT commands.

2013-02-28 Thread Ori Inbar
erial: Add support to optionally send line-feed > at the end of AT commands. > > On Thu, 2013-02-28 at 17:59 +0100, Dan Williams wrote: > > On Thu, 2013-02-28 at 16:34 +0100, Aleksander Morgado wrote: > > > On 02/28/2013 03:20 PM, Dan Williams wrote: > > > >> >

Re: [MM] [PATCH v3] serial: Add support to optionally send line-feed at the end of AT commands.

2013-02-28 Thread Dan Williams
On Thu, 2013-02-28 at 17:59 +0100, Dan Williams wrote: > On Thu, 2013-02-28 at 16:34 +0100, Aleksander Morgado wrote: > > On 02/28/2013 03:20 PM, Dan Williams wrote: > > >> > Also, are you going to suggest a new plugin for MM using this property > > >> > set to TRUE? If so, it may be a good idea to

Re: [MM] [PATCH v3] serial: Add support to optionally send line-feed at the end of AT commands.

2013-02-28 Thread Dan Williams
On Thu, 2013-02-28 at 16:34 +0100, Aleksander Morgado wrote: > On 02/28/2013 03:20 PM, Dan Williams wrote: > >> > Also, are you going to suggest a new plugin for MM using this property > >> > set to TRUE? If so, it may be a good idea to send all relevant commits, > >> > including this one, in the s

Re: [MM] [PATCH v3] serial: Add support to optionally send line-feed at the end of AT commands.

2013-02-28 Thread Aleksander Morgado
On 02/28/2013 03:20 PM, Dan Williams wrote: >> > Also, are you going to suggest a new plugin for MM using this property >> > set to TRUE? If so, it may be a good idea to send all relevant commits, >> > including this one, in the same patch series, along with the plugin. > Now that I think about it,

Re: [MM] [PATCH v3] serial: Add support to optionally send line-feed at the end of AT commands.

2013-02-28 Thread Dan Williams
On Thu, 2013-02-28 at 09:38 +0100, Aleksander Morgado wrote: > On 02/28/2013 09:24 AM, ori.in...@altair-semi.com wrote: > > From: ori inbar > > > > Looks good; some minor comments below. > > Also, are you going to suggest a new plugin for MM using this property > set to TRUE? If so, it may be a

Re: [MM] [PATCH v3] serial: Add support to optionally send line-feed at the end of AT commands.

2013-02-28 Thread Aleksander Morgado
On 02/28/2013 09:24 AM, ori.in...@altair-semi.com wrote: > From: ori inbar > Looks good; some minor comments below. Also, are you going to suggest a new plugin for MM using this property set to TRUE? If so, it may be a good idea to send all relevant commits, including this one, in the same patc

[MM] [PATCH v3] serial: Add support to optionally send line-feed at the end of AT commands.

2013-02-28 Thread ori.in...@altair-semi.com
From: ori inbar --- src/mm-at-serial-port.c | 34 +++--- src/mm-at-serial-port.h |2 ++ src/mm-plugin.c | 19 +++ src/mm-plugin.h |1 + src/mm-port-probe.c |5 + src/mm-port-probe.h |1 + 6 files changed,