Re: [ModemManager] [PATCH 1/4] Split SMS parsing out into a separate file

2011-07-24 Thread Dan Williams
Not sure how these slipped through, but they're all applied. Thanks again! Dan - Original Message - From: "Nathan Williams" To: networkmanager-list@gnome.org Sent: Thursday, June 30, 2011 4:32:00 PM Subject: Re: [ModemManager] [PATCH 1/4] Split SMS parsing out into a s

Re: [ModemManager] [PATCH 1/4] Split SMS parsing out into a separate file

2011-07-02 Thread Marcel Holtmann
Hi Dan, > > > First of four patches that improve SMS handling. This one follows > > > Dan's suggestion some time ago and splits SMS PDU parsing into a > > > separate file, making it accessible to unit tests and to other code > > > that might need it. > > > > you could save yourself a lot of troub

Re: [ModemManager] [PATCH 1/4] Split SMS parsing out into a separate file

2011-07-02 Thread Dan Williams
On Thu, 2011-06-30 at 16:28 -0700, Marcel Holtmann wrote: > Hi Nathan, > > > First of four patches that improve SMS handling. This one follows > > Dan's suggestion some time ago and splits SMS PDU parsing into a > > separate file, making it accessible to unit tests and to other code > > that might

Re: [ModemManager] [PATCH 1/4] Split SMS parsing out into a separate file

2011-06-30 Thread Marcel Holtmann
Hi Nathan, > First of four patches that improve SMS handling. This one follows > Dan's suggestion some time ago and splits SMS PDU parsing into a > separate file, making it accessible to unit tests and to other code > that might need it. you could save yourself a lot of trouble and just use the s

Re: [ModemManager] [PATCH 1/4] Split SMS parsing out into a separate file

2011-06-30 Thread Nathan Williams
This time with the actual patch. On Thu, Jun 30, 2011 at 5:31 PM, Nathan Williams wrote: > First of four patches that improve SMS handling. This one follows > Dan's suggestion some time ago and splits SMS PDU parsing into a > separate file, making it accessible to unit tests and to other code > t

[ModemManager] [PATCH 1/4] Split SMS parsing out into a separate file

2011-06-30 Thread Nathan Williams
First of four patches that improve SMS handling. This one follows Dan's suggestion some time ago and splits SMS PDU parsing into a separate file, making it accessible to unit tests and to other code that might need it. - Nathan ___ networkmanager-lis