Re: [PATCH] Fix manual IP config

2008-03-18 Thread Helmut Schaa
Am Dienstag, 18. März 2008 19:48:28 schrieb Dan Williams: > On Tue, 2008-03-18 at 12:46 -0600, Tambet Ingo wrote: > > On Tue, Mar 18, 2008 at 12:36 PM, Dan Williams <[EMAIL PROTECTED]> wrote: > > > On Tue, 2008-03-18 at 11:37 +0100, Helmut Schaa wrote: > > > > Nevertheless I want to give you an hy

Re: [PATCH] Fix manual IP config

2008-03-18 Thread Dan Williams
On Tue, 2008-03-18 at 12:46 -0600, Tambet Ingo wrote: > On Tue, Mar 18, 2008 at 12:36 PM, Dan Williams <[EMAIL PROTECTED]> wrote: > > On Tue, 2008-03-18 at 11:37 +0100, Helmut Schaa wrote: > > > Nevertheless I want to give you an hypothetical scenario why I would > > prefer it > > > to be set in

Re: [PATCH] Fix manual IP config

2008-03-18 Thread Tambet Ingo
On Tue, Mar 18, 2008 at 12:36 PM, Dan Williams <[EMAIL PROTECTED]> wrote: > On Tue, 2008-03-18 at 11:37 +0100, Helmut Schaa wrote: > > Nevertheless I want to give you an hypothetical scenario why I would > prefer it > > to be set in real_act_stage3_ip_config_start: > > > > As far as I can see

Re: [PATCH] Fix manual IP config

2008-03-18 Thread Dan Williams
On Tue, 2008-03-18 at 11:37 +0100, Helmut Schaa wrote: > Am Montag, 17. März 2008 18:06:18 schrieb Tambet Ingo: > > On Mon, Mar 17, 2008 at 11:02 AM, Helmut Schaa <[EMAIL PROTECTED]> wrote: > > > Why not call it in real_act_stage3_ip_config_start as it is done when > > > using DHCP? That would be

Re: [PATCH] Fix manual IP config

2008-03-18 Thread Helmut Schaa
Am Montag, 17. März 2008 18:06:18 schrieb Tambet Ingo: > On Mon, Mar 17, 2008 at 11:02 AM, Helmut Schaa <[EMAIL PROTECTED]> wrote: > > Why not call it in real_act_stage3_ip_config_start as it is done when > > using DHCP? That would be much clearer, no? > > It's much cleaner to not keep dhcp manage

Re: [PATCH] Fix manual IP config

2008-03-17 Thread Tambet Ingo
On Mon, Mar 17, 2008 at 11:02 AM, Helmut Schaa <[EMAIL PROTECTED]> wrote: > Why not call it in real_act_stage3_ip_config_start as it is done when using > DHCP? That would be much clearer, no? It's much cleaner to not keep dhcp manager around when a device is deactivated. It's not only cleaner, i

Re: [PATCH] Fix manual IP config

2008-03-17 Thread Helmut Schaa
Am Montag, 17. März 2008 17:39:12 schrieb Tambet Ingo: > On Mon, Mar 17, 2008 at 10:32 AM, Helmut Schaa <[EMAIL PROTECTED]> wrote: > > 2. Assume a DHCP-connection on that device. When you switch to a manual > > connection priv->dhcp_manager remains set and therefor the manual IP > > configuratio

Re: [PATCH] Fix manual IP config

2008-03-17 Thread Tambet Ingo
On Mon, Mar 17, 2008 at 10:32 AM, Helmut Schaa <[EMAIL PROTECTED]> wrote: > nm_device_get_use_dhcp returns true when "priv->dhcp_manager != NULL". > > 1. Since priv->dhcp_manager does not get initialized anywhere it may be != > NULL but not set to a correct value. Therefore nm_device_get_use_dhc

Re: [PATCH] Fix manual IP config

2008-03-17 Thread Helmut Schaa
Am Montag, 17. März 2008 17:14:34 schrieb Tambet Ingo: > 2008/3/17 Helmut Schaa <[EMAIL PROTECTED]>: > > I had some problems with manual IP configuration being ignored by NM. > > Attached patch for trunk fixes it for me. > > I don't understand why or how this patch could fix the problem though. >

Re: [PATCH] Fix manual IP config

2008-03-17 Thread Tambet Ingo
2008/3/17 Helmut Schaa <[EMAIL PROTECTED]>: > I had some problems with manual IP configuration being ignored by NM. > Attached patch for trunk fixes it for me. I don't understand why or how this patch could fix the problem though. The call you added, nm_device_set_use_dhcp (self, FALSE); makes

[PATCH] Fix manual IP config

2008-03-17 Thread Helmut Schaa
Hi, I had some problems with manual IP configuration being ignored by NM. Attached patch for trunk fixes it for me. Regards, Helmut Index: src/nm-device.c === --- src/nm-device.c (Revision 3469) +++ src/nm-device.c (Arbeitskopie) @@