Re: [PATCH] Fix unterminated buffer after readlink() call

2011-10-17 Thread Thomas Jarosch
On Friday, 14. October 2011 17:50:14 Dan Williams wrote: > > Good catch, I missed the memset() call. > > > > And if readlink() doesn't fill the buffer, > > > > > the remaining bytes will already be set to 0 by the memset, AFAICT. > > > Are you seeing a crash here or was this from visual inspecti

Re: [PATCH] Fix unterminated buffer after readlink() call

2011-10-14 Thread Dan Williams
On Fri, 2011-10-14 at 17:26 +0200, Thomas Jarosch wrote: > Hi Dan, > > On 10/14/2011 05:14 PM, Dan Williams wrote: > >> --- a/src/nm-device-ethernet.c > >> +++ b/src/nm-device-ethernet.c > >> @@ -343,6 +343,7 @@ _update_s390_subchannels (NMDeviceEthernet *self) > >>while ((item = g_dir_read_na

Re: [PATCH] Fix unterminated buffer after readlink() call

2011-10-14 Thread Thomas Jarosch
Hi Dan, On 10/14/2011 05:14 PM, Dan Williams wrote: >> --- a/src/nm-device-ethernet.c >> +++ b/src/nm-device-ethernet.c >> @@ -343,6 +343,7 @@ _update_s390_subchannels (NMDeviceEthernet *self) >> while ((item = g_dir_read_name (dir))) { >> char buf[50]; >> char *cdev

Re: [PATCH] Fix unterminated buffer after readlink() call

2011-10-14 Thread Dan Williams
On Fri, 2011-10-14 at 13:17 +0200, Thomas Jarosch wrote: > Patch is not compile tested as I lack some > dependencies to build NM on this box. > > Signed-off-by: Thomas Jarosch > --- > src/nm-device-ethernet.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/src/

[PATCH] Fix unterminated buffer after readlink() call

2011-10-14 Thread Thomas Jarosch
Patch is not compile tested as I lack some dependencies to build NM on this box. Signed-off-by: Thomas Jarosch --- src/nm-device-ethernet.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/nm-device-ethernet.c b/src/nm-device-ethernet.c index 8556c5b..87cd57e 1006