Re: [PATCH] Multiple search domains in OpenVPN

2013-03-19 Thread Vsevolod Velichko
> 3) Last, in the IPv6 code, you've got "priv->ip4_config" which I'll assume is a copy & paste error :) Oh, my fail. I fixed all the things you mentioned and attached a new patch file. Thanks for your help with the both patches. Best wishes and have a nice day, Vsevolod Velichko 2013/3/18 Dan W

Re: [PATCH] Multiple search domains in OpenVPN

2013-03-18 Thread Dan Williams
On Sat, 2013-03-16 at 03:55 +0400, Vsevolod Velichko wrote: > Hello all, > > I'm widely using OpenVPN and recently found that network-manager-openvpn > plugin just ignores all but first search domains it has to send to NM. > > I wrote a little patch, that obviously fixes the issue, however I'm no

Re: [PATCH] Multiple search domains in OpenVPN

2013-03-18 Thread Dan Williams
On Mon, 2013-03-18 at 21:01 +0400, Vsevolod Velichko wrote: > Thanks, Dan! > > Your way is much simpler than one of mine. Looks good; thanks! Pushed this. I added one piece because I forgot about it in my earlier reply; we do need to free the GPtrArray when no domains are received from OpenVPN,

Re: [PATCH] Multiple search domains in OpenVPN

2013-03-18 Thread Vsevolod Velichko
Thanks, Dan! Your way is much simpler than one of mine. I tested it and found it working, so I'm attaching a new patch. Best wishes and have a nice day, Vsevolod Velichko 2013/3/18 Dan Williams > On Sat, 2013-03-16 at 03:55 +0400, Vsevolod Velichko wrote: > > Hello all, > > > > I'm widely us

Re: [PATCH] Multiple search domains in OpenVPN

2013-03-18 Thread Dan Williams
On Sat, 2013-03-16 at 03:55 +0400, Vsevolod Velichko wrote: > Hello all, > > I'm widely using OpenVPN and recently found that network-manager-openvpn > plugin just ignores all but first search domains it has to send to NM. > > I wrote a little patch, that obviously fixes the issue, however I'm no

[PATCH] Multiple search domains in OpenVPN

2013-03-18 Thread Vsevolod Velichko
Hello all, I'm widely using OpenVPN and recently found that network-manager-openvpn plugin just ignores all but first search domains it has to send to NM. I wrote a little patch, that obviously fixes the issue, however I'm not familiar with the libglib API at all, so it would be nice if someone c