Re: [PATCH] add UnlockRetries property to the modem dbus interface

2010-06-30 Thread Torgny Johansson
Pushed. Thank you! Then we also need to address the issue that the UnlockRequired and UnlockRetries properties don't get updated if you enter an invalid pin code. That was the reason for the change (removed the return on error) I did in send_pin_done in the original patch. The issue

RE: [PATCH] add UnlockRetries property to the modem dbus interface

2010-06-23 Thread Torgny Johansson
-Original Message- From: Dan Williams [mailto:d...@redhat.com] Sent: den 23 juni 2010 02:21 To: Torgny Johansson Cc: networkmanager-list@gnome.org Subject: RE: [PATCH] add UnlockRetries property to the modem dbus interface On Wed, 2010-06-09 at 16:03 +0200, Torgny Johansson wrote

Re: [PATCH] add UnlockRetries property to the modem dbus interface

2010-06-23 Thread Robert Vogelgesang
Hey all, On Wed, Jun 23, 2010 at 09:51:07AM +0200, Torgny Johansson wrote: -Original Message- From: Dan Williams [mailto:d...@redhat.com] Sent: den 23 juni 2010 02:21 To: Torgny Johansson Cc: networkmanager-list@gnome.org Subject: RE: [PATCH] add UnlockRetries property

RE: [PATCH] add UnlockRetries property to the modem dbus interface

2010-06-23 Thread Torgny Johansson
-Original Message- From: networkmanager-list-boun...@gnome.org [mailto:networkmanager-list-boun...@gnome.org] On Behalf Of Robert Vogelgesang Sent: den 23 juni 2010 10:19 To: networkmanager-list@gnome.org Subject: Re: [PATCH] add UnlockRetries property to the modem dbus

RE: [PATCH] add UnlockRetries property to the modem dbus interface

2010-06-22 Thread Dan Williams
-list@gnome.org Subject: RE: [PATCH] add UnlockRetries property to the modem dbus interface Hi! Any other comments on this patch? Regards Torgny -Original Message- From: networkmanager-list-boun...@gnome.org [mailto:networkmanager-list-boun...@gnome.org] On Behalf

RE: [PATCH] add UnlockRetries property to the modem dbus interface

2010-06-09 Thread Torgny Johansson
@gnome.org Subject: [PATCH] add UnlockRetries property to the modem dbus interface Hi! This is a new patch that fixes the issues from your comments. Now only a property containing the UnlockRetries for the currently locked pin type is added and no extra dbus method. I also

Re: [PATCH] add UnlockRetries property to the modem dbus interface

2010-06-02 Thread Dan Williams
On Sun, 2010-05-30 at 18:53 +0200, Frederik Nnaji wrote: hahaah, here's why: On Fri, May 28, 2010 at 15:25, Torgny Johansson torgny.johans...@ericsson.com wrote: While not entirely sure how, I'm still very glad to hear that my contribution may have that unexpected

Re: [PATCH] add UnlockRetries property to the modem dbus interface

2010-05-30 Thread Frederik Nnaji
hahaah, here's why: On Fri, May 28, 2010 at 15:25, Torgny Johansson torgny.johans...@ericsson.com wrote: While not entirely sure how, I'm still very glad to hear that my contribution may have that unexpected positive impact! ;) Here's the most personal Use Case you'll probably ever get out

[PATCH] add UnlockRetries property to the modem dbus interface

2010-05-27 Thread Torgny Johansson
Hi! This is a new patch that fixes the issues from your comments. Now only a property containing the UnlockRetries for the currently locked pin type is added and no extra dbus method. I also removed the change in send_pin_done, but as mentioned in a previously mail that will still have to be