Re: [PATCH] connection-editor: Fix handling of wired 802-1x security setting

2016-08-26 Thread Beniamino Galvani
On Thu, Aug 25, 2016 at 09:02:59PM +0300, Mikhail Efremov wrote: > On Thu, 25 Aug 2016 20:46:01 +0300 Mikhail Efremov wrote: > > Function nm_setting_duplicate() can't copy object's data. > > As a result a value of the "Ignore CA certificate" checkbox was > > always lost. So don't copy settings, jus

Re: [PATCH] connection-editor: Fix handling of wired 802-1x security setting

2016-08-25 Thread Mikhail Efremov
On Thu, 25 Aug 2016 20:46:01 +0300 Mikhail Efremov wrote: > Function nm_setting_duplicate() can't copy object's data. > As a result a value of the "Ignore CA certificate" checkbox was > always lost. So don't copy settings, just use g_object_ref() again > and remove the 8021x setting from the tempor

[PATCH] connection-editor: Fix handling of wired 802-1x security setting

2016-08-25 Thread Mikhail Efremov
Function nm_setting_duplicate() can't copy object's data. As a result a value of the "Ignore CA certificate" checkbox was always lost. So don't copy settings, just use g_object_ref() again and remove the 8021x setting from the temporary object to prevent the clearing of secrets. Fixes: c21d56dd220