Re: [PATCH] gsm: pass the PPP auth preferences for STATIC and DHCP device use

2012-03-16 Thread Andrew Bird (Sphere Systems)
On Thursday 15 March 2012, Dan Williams wrote: > On Mon, 2012-03-12 at 20:01 +, Andrew Bird wrote: > > When using the either DHCP or STATIC IpMethods the modem manager > > or device itself negotiates the PPP session so we need to pass > > the authentication preferences through to MM. > > > > N

Re: [PATCH] gsm: pass the PPP auth preferences for STATIC and DHCP device use

2012-03-15 Thread Dan Williams
On Mon, 2012-03-12 at 20:01 +, Andrew Bird wrote: > When using the either DHCP or STATIC IpMethods the modem manager > or device itself negotiates the PPP session so we need to pass > the authentication preferences through to MM. > > Notes: > 1/ Using a bitfield now that happens to match

Re: [PATCH] gsm: pass the PPP auth preferences for STATIC and DHCP device use

2012-03-12 Thread Andrew Bird (Sphere Systems)
Hi Dan, On Monday 12 March 2012, Dan Williams wrote: > On Wed, 2012-03-07 at 12:37 +, Andrew Bird wrote: > > When using the either DHCP or STATIC IpMethods the modem manager > > or device itself negotiates the PPP session, so we need to pass > > the authentication preferences through to MM. >

[PATCH] gsm: pass the PPP auth preferences for STATIC and DHCP device use

2012-03-12 Thread Andrew Bird
When using the either DHCP or STATIC IpMethods the modem manager or device itself negotiates the PPP session so we need to pass the authentication preferences through to MM. Notes: 1/ Using a bitfield now that happens to match the Ericsson in the lower orders so that it's far more tidy.

Re: [PATCH] gsm: pass the PPP auth preferences for STATIC and DHCP device use

2012-03-12 Thread Dan Williams
On Wed, 2012-03-07 at 12:37 +, Andrew Bird wrote: > When using the either DHCP or STATIC IpMethods the modem manager > or device itself negotiates the PPP session, so we need to pass > the authentication preferences through to MM. Instead of individual keys, lets use a u32 bitfield here. If t

[PATCH] gsm: pass the PPP auth preferences for STATIC and DHCP device use

2012-03-07 Thread Andrew Bird (Sphere Systems)
Hi all, Currently when GSM devices are connected using Simple.Connect() they have no idea of the user's PPP auth preferences, but either Modem Manager or the device itself has to negotiate the PPP session. The patch just sent does nothing more than pass through those values in the prefe

[PATCH] gsm: pass the PPP auth preferences for STATIC and DHCP device use

2012-03-07 Thread Andrew Bird
When using the either DHCP or STATIC IpMethods the modem manager or device itself negotiates the PPP session, so we need to pass the authentication preferences through to MM. Signed-off-by: Andrew Bird --- src/modem-manager/nm-modem-gsm.c | 12 1 files changed, 12 insertions(+), 0