Re: [PATCH] modem: map modemmanager errors more detailed

2011-11-14 Thread Dan Williams
On Sun, 2011-11-13 at 19:06 +0100, Thomas Bechtold wrote: Hi, attached is a patch to handle some ModemManager errors more detailed. But i still have some questions about the code and i'm not sure if this patch is the correct way to solve the problem that NM does not know the exact reason

Re: [PATCH] modem: map modemmanager errors more detailed

2011-11-14 Thread Thomas Bechtold
On 15/11/11 00:32, Dan Williams wrote: - in NM/include/NetworkManager.h are some NMDeviceStateReason defined which are never used. eg NM_DEVICE_STATE_REASON_MODEM_NO_DIAL_TONE, NM_DEVICE_STATE_REASON_MODEM_NO_CARRIER, NM_DEVICE_STATE_REASON_MODEM_DIAL_FAILED,

[PATCH] modem: map modemmanager errors more detailed

2011-11-13 Thread Thomas Bechtold
Hi, attached is a patch to handle some ModemManager errors more detailed. But i still have some questions about the code and i'm not sure if this patch is the correct way to solve the problem that NM does not know the exact reason why a modem connection fails. Here are my questions: - should NM