Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-22 Thread Jelle Licht
Thomas Haller writes: > On Thu, 2019-07-18 at 20:39 +0200, Jelle Licht wrote: >> Thomas Haller writes: >> >> > [snip] >> > if you have >> > >> > /gnu/store/123verylonghash-networkmanager-1.18.2/ >> > /gnu/store/234verylonghash-networkmanager-1.20.0/ >> > >> > and >> > >> > /gnu/store/3

Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-22 Thread Thomas Haller via networkmanager-list
On Thu, 2019-07-18 at 20:39 +0200, Jelle Licht wrote: > Thomas Haller writes: > > > [snip] > > if you have > > > > /gnu/store/123verylonghash-networkmanager-1.18.2/ > > /gnu/store/234verylonghash-networkmanager-1.20.0/ > > > > and > > > > /gnu/store/345verylonghash-networkmanager-openvpn

Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-18 Thread Jelle Licht
Thomas Haller writes: > [snip] > if you have > > /gnu/store/123verylonghash-networkmanager-1.18.2/ > /gnu/store/234verylonghash-networkmanager-1.20.0/ > > and > > /gnu/store/345verylonghash-networkmanager-openvpn-1.2.8/ > > then the plugin should work with both versions of NetworkManager. H

Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-18 Thread Thomas Haller via networkmanager-list
On Thu, 2019-07-18 at 15:53 +0200, Jelle Licht wrote: > Thomas Haller writes: > > > On Thu, 2019-07-18 at 13:27 +0200, Jelle Licht wrote: > > > Thomas Haller writes: > > > > > > > On Wed, 2019-07-17 at 11:46 +0200, Jelle Licht wrote: > > > > [snip] > > > > But the daemon runs as root, so settin

Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-18 Thread Jelle Licht
Thomas Haller writes: > On Thu, 2019-07-18 at 13:27 +0200, Jelle Licht wrote: >> Thomas Haller writes: >> >> > On Wed, 2019-07-17 at 11:46 +0200, Jelle Licht wrote: >> > [snip] >> > But the daemon runs as root, so setting NM_VPN_PLUGIN_DIR requires >> > you >> > to become root, to restart the d

Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-18 Thread Thomas Haller via networkmanager-list
On Thu, 2019-07-18 at 13:27 +0200, Jelle Licht wrote: > Thomas Haller writes: > > > On Wed, 2019-07-17 at 11:46 +0200, Jelle Licht wrote: > > [snip] > > But the daemon runs as root, so setting NM_VPN_PLUGIN_DIR requires > > you > > to become root, to restart the daemon, and to set the environment

Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-18 Thread Jelle Licht
Thomas Haller writes: > On Wed, 2019-07-17 at 11:46 +0200, Jelle Licht wrote: > [snip] > But the daemon runs as root, so setting NM_VPN_PLUGIN_DIR requires you > to become root, to restart the daemon, and to set the environment > variable (in the systemd service file). At that point, you could ju

Re: [PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-17 Thread Thomas Haller via networkmanager-list
On Wed, 2019-07-17 at 11:46 +0200, Jelle Licht wrote: > From: Tomáš Čech Hi, This was not done intentionally (so far). Clients (nm-applet, nmcli) may load the client parts of the VPN plugins (the libnm.plugin setting from the .name file). That's useful to show the GTK configuration dialog or i

[PATCH] vpn-manager: respect NM_VPN_PLUGIN_DIR

2019-07-17 Thread Jelle Licht
From: Tomáš Čech --- src/vpn/nm-vpn-manager.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/vpn/nm-vpn-manager.c b/src/vpn/nm-vpn-manager.c index 36043c935..e73ccac47 100644 --- a/src/vpn/nm-vpn-manager.c +++ b/src/vpn/nm-vpn-manager.c @@ -220,6 +220,7 @@ nm_vpn_manager