Re: ModemManager: [PATCH 2/2] Improvements to SIM PIN handling

2011-11-03 Thread Eric Shienbrood
Why is the new property in the Modem.Gsm.Card interface, and not in the Modem one (close to UnlockRequired and UnlockRetries). Same for the new MMModemGsmFacility flags, why not have them in the Modem interface. Some locks come from the card, but not all, so it's not really card-specific.

Re: ModemManager: [PATCH 2/2] Improvements to SIM PIN handling

2011-10-26 Thread Aleksander Morgado
Hey Eric, Some comments inline below. On Wed, 2011-10-19 at 15:42 -0400, Eric Shienbrood wrote: From b129d263ec1674462c218b4ec91260cf082bf77e Mon Sep 17 00:00:00 2001 From: Eric Shienbrood e...@google.com Date: Thu, 11 Aug 2011 13:58:59 -0400 Subject: [PATCH] Added new property to track

Re: ModemManager: [PATCH 2/2] Improvements to SIM PIN handling

2011-10-26 Thread Dan Williams
On Wed, 2011-10-19 at 15:42 -0400, Eric Shienbrood wrote: Looks good, though taking my comments to part 1 into consideration I'm not entirely sure what to do here. Facility locks are slightly different than the PIN locks we might get from PIN, yet each have a number of retries, and at least some

Re: ModemManager: [PATCH 2/2] Improvements to SIM PIN handling

2011-10-26 Thread Dan Williams
On Wed, 2011-10-26 at 17:59 +0200, Aleksander Morgado wrote: Hey Eric, Some comments inline below. On Wed, 2011-10-19 at 15:42 -0400, Eric Shienbrood wrote: From b129d263ec1674462c218b4ec91260cf082bf77e Mon Sep 17 00:00:00 2001 From: Eric Shienbrood e...@google.com Date: Thu, 11 Aug

ModemManager: [PATCH 2/2] Improvements to SIM PIN handling

2011-10-19 Thread Eric Shienbrood
From b129d263ec1674462c218b4ec91260cf082bf77e Mon Sep 17 00:00:00 2001 From: Eric Shienbrood e...@google.com Date: Thu, 11 Aug 2011 13:58:59 -0400 Subject: [PATCH] Added new property to track which facility locks are enabled. The property EnabledFacilityLocks on the .Modem.Gsm.Card interface is