Re: [Nfs-ganesha-devel] FW: New Defects reported by Coverity Scan for nfs-ganesha

2015-07-13 Thread Matt W. Benjamin
Yup, will do. Was going to do it over the weekend, but got tied up. Matt - "Frank Filz" wrote: > Looks like we can clear all of these. I think they should mostly all > be marked as intentional, our use of flags to control when lock/unlock > is done is hard for an automated tool to follow (

Re: [Nfs-ganesha-devel] FW: New Defects reported by Coverity Scan for nfs-ganesha

2015-07-13 Thread Frank Filz
Looks like we can clear all of these. I think they should mostly all be marked as intentional, our use of flags to control when lock/unlock is done is hard for an automated tool to follow (it's not even always that clear to me... I wish in some cases we would use functions like foo_locked that a

Re: [Nfs-ganesha-devel] FW: New Defects reported by Coverity Scan for nfs-ganesha

2015-07-13 Thread Frank Filz
> On 7/12/15 8:05 AM, William Allen Simpson wrote: > > Noting that I've had for some weeks (Jun 19) a replacement for > SVC_RELEASE() that uses an inline function instead. > Coverity seems to be better with inline, so this will probably go away on its > own. > > That patch happens to be called: >