[Nfs-ganesha-devel] Need a second opinion on some code

2017-06-13 Thread Frank Filz
Hmm, I think the following code blows our dirent cache if we are not able to add the dirent for a created file to a chunk (either because there isn't a chunk to add it to, or the FSAL is not RGW): if (new_dir_entry == allocated_dir_entry && mdcache_param.dir.avl_chunk > 0) {

Re: [Nfs-ganesha-devel] Need a second opinion on some code

2017-06-14 Thread Daniel Gryniewicz
I think it's worse than that. It will blow away all dirents in a directory on any rename, lookup, or link, if the FSAL is not RGW (or rather, if the FSAL doesn't support computing cookies). I'm not sure how to handle this, though. Just putting the dirent into a loose list breaks enumeration orde

Re: [Nfs-ganesha-devel] Need a second opinion on some code

2017-06-14 Thread Matt Benjamin
: "NFS Ganesha Developers" > Sent: Wednesday, June 14, 2017 9:56:33 AM > Subject: Re: [Nfs-ganesha-devel] Need a second opinion on some code > > I think it's worse than that. It will blow away all dirents in a > directory on any rename, lookup, or link, if the FSAL is

Re: [Nfs-ganesha-devel] Need a second opinion on some code

2017-06-14 Thread Frank Filz
But I might also not have goofed up, the previous code may have dumped dirents anyway... Frank > - Original Message - > > From: "Daniel Gryniewicz" > > To: "Frank Filz" > > Cc: "NFS Ganesha Developers" > > Sent: Wednesday, Jun