Re: [Nfs-ganesha-devel] review request https://review.gerrithub.io/#/c/390652/

Aah. Now I could publish the comments. Thank you Matt. Regards, Satya. On Fri, Mar 9, 2018 at 9:53 PM, Matt Benjamin wrote: > Hi Satya, > > To reply, to a reply on the top level (can even be blank), all your > inline comments will publish then. > > Matt > > On Fri, Mar 9,

Re: [Nfs-ganesha-devel] review request https://review.gerrithub.io/#/c/390652/

Hi Satya, To reply, to a reply on the top level (can even be blank), all your inline comments will publish then. Matt On Fri, Mar 9, 2018 at 11:21 AM, Satya Prakash GS wrote: > I had replied to the comments on the same day Matt posted. My replies show > as drafts,

Re: [Nfs-ganesha-devel] review request https://review.gerrithub.io/#/c/390652/

I had replied to the comments on the same day Matt posted. My replies show as drafts, looks like I have to publish them. I don't see a publish button either. Can you guys help me out. Thanks, Satya. On 9 Mar 2018 20:48, "Frank Filz" wrote: > Matt had called for

Re: [Nfs-ganesha-devel] review request https://review.gerrithub.io/#/c/390652/

Matt had called for additional discussion on this, so let's get that discussion going. Could you address Matt's questions? Frank > -Original Message- > From: Satya Prakash GS [mailto:g.satyaprak...@gmail.com] > Sent: Friday, March 9, 2018 4:17 AM > To:

[Nfs-ganesha-devel] review request https://review.gerrithub.io/#/c/390652/

Can somebody please review this change : https://review.gerrithub.io/#/c/390652/ It addresses this issue : Leak in DRC when client disconnects nfs_dupreq_finish doesn't call put_drc always. It does only if it meets certain criteria (drc_should_retire). This can leak the drc and the dupreq