Re: My module is overriding the rate limiting module status for POST requests.

2022-12-04 Thread Maxim Dounin
Hello! On Sun, Dec 04, 2022 at 08:32:13PM +, Jeremy Cocks via nginx wrote: > At the moment, no authz is really happening. During this testing I was > statically setting the advice from the policy server to be 200. > Setting this in the access phase works fine for me with no random hitches, >

Re: My module is overriding the rate limiting module status for POST requests.

2022-12-04 Thread Jeremy Cocks via nginx
At the moment, no authz is really happening. During this testing I was statically setting the advice from the policy server to be 200. Setting this in the access phase works fine for me with no random hitches, so that's fixed. Thanks. For future reference, is there anything to go by which dictates

Re: My module is overriding the rate limiting module status for POST requests.

2022-12-04 Thread Maxim Dounin
Hello! On Sun, Dec 04, 2022 at 08:00:04PM +, Jeremy Cocks via nginx wrote: > > Your observation is wrong. Rate limiting as implemented in the > > limit_req module does not distinguish between different request > > methods and always works after reading the request header > > Sorry, I wasn't

Re: My module is overriding the rate limiting module status for POST requests.

2022-12-04 Thread Jeremy Cocks via nginx
> Your observation is wrong. Rate limiting as implemented in the > limit_req module does not distinguish between different request > methods and always works after reading the request header Sorry, I wasn't clear there. It kicks in for POST requests without my module ;) > does not distinguish be

Re: My module is overriding the rate limiting module status for POST requests.

2022-12-04 Thread Maxim Dounin
Hello! On Sun, Dec 04, 2022 at 05:29:29PM +, Jeremy Cocks via nginx wrote: > Actually analysing the log files of this, it seems the rate limiting module > never kicks in for POST requests, my module just sets the status and bails. > Assuming this is because POST actually needs to write conten

Re: My module is overriding the rate limiting module status for POST requests.

2022-12-04 Thread Maxim Dounin
Hello! On Sun, Dec 04, 2022 at 04:57:17PM +, Jeremy Cocks via nginx wrote: > I am developing an AuthZ module. [...] > Setting my module to run in the `precontent` phase allows this to work, so > it's all happening in rewrite (where the rate limiting module would be > kicking in). > > I obv

Re: My module is overriding the rate limiting module status for POST requests.

2022-12-04 Thread Jeremy Cocks via nginx
Actually analysing the log files of this, it seems the rate limiting module never kicks in for POST requests, my module just sets the status and bails. Assuming this is because POST actually needs to write content? On Sun, 4 Dec 2022 at 16:57, Jeremy Cocks wrote: > I am developing an AuthZ modul

My module is overriding the rate limiting module status for POST requests.

2022-12-04 Thread Jeremy Cocks via nginx
I am developing an AuthZ module. While testing using the rate limiting module. I can see rate limiting kick in for GET requests fine (it's tuned extra low to demonstrate this case): curl -s -I http://localhost/login?{1..3} HTTP/1.1 200 OK Server: nginx/1.21.6 Date: Sun, 04 Dec 2022 16:43:17 GMT C

Re: Trying to confirm syntax of CLIENT_MAX_BODY_SIZE environment variable

2022-12-04 Thread Sergey A. Osokin
Hi David, On Sat, Dec 03, 2022 at 10:07:51AM -0800, David Karr wrote: > > I was told that v1.22 of nginx will look for a CLIENT_MAX_BODY_SIZE > environment variable to configure the "client_max_body_size" configuration > property. I'm having trouble finding a clear statement of what the > requir

Re: Restarting service takes too much time

2022-12-04 Thread blason
Yes - He is right; everything is revolves around DNS and even my error is with DNS resolving as it was not able to resolve the ocsp.godaddy.com hence please troubelshoot from DNS perspetive. Posted at Nginx Forum: https://forum.nginx.org/read.php?2,295945,295964#msg-295964 __

Re: Restarting service takes too much time

2022-12-04 Thread A. Schulze via nginx
Am 04.12.22 um 08:04 schrieb blason: Yes - He is right; everything is revolves around DNS and even my error is with DNS resolving as it was not able to resolve the ocsp.godaddy.com hence please troubelshoot from DNS perspetive. Hello List, To avoid this problems I prefer https://nginx.org/r/