Re: Bugfix: graceful shutdown of old worker processes might be delayed when using HTTP/2.

2024-07-18 Thread Roman Arutyunyan
Hello, > On 11 Jul 2024, at 1:12 PM, Roman Arutyunyan wrote: > > Hi Sébastien, > >> On 9 Jul 2024, at 5:52 PM, Sébastien Rebecchi >> wrote: >> >> Hi! >> >> We are using nginx a lot in our company for high HTTP/2 workloads. >> >>

Re: [PATCH]HTTP/2 connection not properly closing during graceful shutdown

2024-07-18 Thread Roman Arutyunyan
Hi, On Thu, Jul 11, 2024 at 08:51:54PM +0400, Sergey Kandaurov wrote: > > > On 11 Jul 2024, at 13:33, Roman Arutyunyan wrote: > > > > Hi, > > > > On Mon, May 06, 2024 at 11:14:24AM +0800, ka...@kasei.im wrote: > >> Hello, > >>

[nginx] HTTP/2: close connections initialized during graceful shutdown.

2024-07-18 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/d1b8568f3042 branches: changeset: 9270:d1b8568f3042 user: Kasei Wang date: Thu Jul 18 17:43:25 2024 +0400 description: HTTP/2: close connections initialized during graceful shutdown. In some rare cases, graceful shutdown may happen while

Re: nginx: [emerg] no handler for server in /etc/nginx/nginx.conf:7

2024-07-11 Thread Roman Arutyunyan
Добры день, > On 11 Jul 2024, at 8:46 PM, Hennadii Makhomed wrote: > > On 11.07.2024 16:58, Roman Arutyunyan wrote: > >>>> stream { >>>>server { >>>>listen [::]:443 bind default_server ssl; >>>>listen 4

Re: nginx: [emerg] no handler for server in /etc/nginx/nginx.conf:7

2024-07-11 Thread Roman Arutyunyan
Добрый день, > On 27 Jun 2024, at 5:02 PM, Roman Arutyunyan wrote: > > Добрый день,. > >> On 5 Jun 2024, at 7:41 PM, Gena Makhomed wrote: >> >> Здравствуйте, All! >> >> есть такой конфиг: >> >> # cat /etc/nginx/nginx.conf >> &g

[nginx] Stream: allow servers with no handler.

2024-07-11 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/072ca4906154 branches: changeset: 9269:072ca4906154 user: Roman Arutyunyan date: Thu Jun 27 17:29:56 2024 +0400 description: Stream: allow servers with no handler. Previously handlers were mandatory. However they are not always needed

Re: [PATCH]HTTP/2 connection not properly closing during graceful shutdown

2024-07-11 Thread Roman Arutyunyan
c->idle = 1; > ngx_reusable_connection(c, 0); > > +if (ngx_exiting) { > +ngx_http_v2_finalize_connection(h2c, NGX_HTTP_V2_NO_ERROR); > +return; > +} I'd move this up a few lines. > + > if (c->buffer) { > p = c->buffer->

Re: Bugfix: graceful shutdown of old worker processes might be delayed when using HTTP/2.

2024-07-11 Thread Roman Arutyunyan
wn (12 worker > processes, when reload signal is sent then it takes more than 3 minutes until > the last worker is down), which is a problem in our case. Yes, this works started in April and was suspended due to switching to other important tasks. We will finish it shortly. Thanks

Re: [PATCH 8 of 9] Upstream: disable re-resolve functionality on Windows

2024-07-11 Thread Roman Arutyunyan
Hello, On Wed, Jul 10, 2024 at 05:16:07PM +0400, Roman Arutyunyan wrote: > Hi, > > On Thu, Jun 13, 2024 at 03:29:03PM -0700, Aleksei Bavshin wrote: > > # HG changeset patch > > # User Aleksei Bavshin > > # Date 1712181327 25200 > > # Wed Apr 03

Re: [PATCH 1 of 9] Upstream: re-resolvable servers

2024-07-10 Thread Roman Arutyunyan
Hi, On Tue, Jul 09, 2024 at 01:21:18PM -0700, Aleksei Bavshin wrote: > On 7/8/2024 7:20 AM, Roman Arutyunyan wrote: > > Hi, > > > > On Thu, Jun 13, 2024 at 03:28:56PM -0700, Aleksei Bavshin wrote: > > > # HG changeset patch > > > # User Ruslan

Re: [PATCH 8 of 9] Upstream: disable re-resolve functionality on Windows

2024-07-10 Thread Roman Arutyunyan
quot;resolve") == 0) { > resolve = 1; > continue; > _______ > nginx-devel mailing list > nginx-devel@nginx.org > https://mailman.nginx.org/mailman/listinfo/nginx-devel -- Ro

Re: [PATCH 1 of 9] Upstream: re-resolvable servers

2024-07-09 Thread Roman Arutyunyan
Hi, On Mon, Jul 08, 2024 at 06:20:58PM +0400, Roman Arutyunyan wrote: > Hi, > > On Thu, Jun 13, 2024 at 03:28:56PM -0700, Aleksei Bavshin wrote: > > # HG changeset patch > > # User Ruslan Ermilov > > # Date 1392462754 -14400 > > # Sat Feb 15

Re: [PATCH 6 of 9] Upstream: per-upstream resolver

2024-07-08 Thread Roman Arutyunyan
Hi, On Thu, Jun 13, 2024 at 03:29:01PM -0700, Aleksei Bavshin wrote: > # HG changeset patch > # User Vladimir Homutov > # Date 1571405595 -10800 > # Fri Oct 18 16:33:15 2019 +0300 > # Node ID 621ba257aeac3017ea83b24fafa201e07c1c7756 > # Parent 238c1695d3b7450159ba0c03509584683bf25f9b >

Re: [PATCH 7 of 9] Upstream: copy upstream zone DNS valid time during config reload

2024-07-08 Thread Roman Arutyunyan
imer(event, ngx_max(uscf->resolver_timeout, 1000)); > +/* don't delay zombie cleanup longer than resolver_timeout */ > +timer = (ngx_msec_t) 1000 * (valid > now ? valid - now + 1 : 1); > +timer = ngx_min(timer, uscf->resolver_timeout); > + >Here +ngx_add_timer(event, ngx_max(timer, 1000)); Same here. > } > > > @@ -1024,6 +1039,8 @@ again: > > done: > > +host->valid = ctx->valid; > + > ngx_stream_upstream_rr_peers_unlock(peers); > > while (++i < ctx->naddrs) { > ___ > nginx-devel mailing list > nginx-devel@nginx.org > https://mailman.nginx.org/mailman/listinfo/nginx-devel -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH 4 of 9] Core: inheritance of non-reusable shared memory zones

2024-07-08 Thread Roman Arutyunyan
On Thu, Jun 13, 2024 at 03:28:59PM -0700, Aleksei Bavshin wrote: > # HG changeset patch > # User Ruslan Ermilov > # Date 1509736941 -10800 > # Fri Nov 03 22:22:21 2017 +0300 > # Node ID 90ef6f74980d5e46c95aa32375a58bb8eb56122e > # Parent 8b7fcded3983023229de1a6df5e2e0b857ee1bc9 > Core:

Re: [PATCH 1 of 9] Upstream: re-resolvable servers

2024-07-08 Thread Roman Arutyunyan
by peer.get and > decremented by peer.free. When a server is removed, it is removed from > the list of servers and is marked as "zombie". The memory allocated by > a zombie peer is freed only when its reference count becomes zero. > > Re-resolvable servers utilize timers

[PATCH] Stream: allow servers with no handler

2024-06-27 Thread Roman Arutyunyan
# HG changeset patch # User Roman Arutyunyan # Date 1719494996 -14400 # Thu Jun 27 17:29:56 2024 +0400 # Node ID 252582428b60f3422aa3b25dac8cca94edd43c34 # Parent 4fbc38ad3c8a8ed798676b8aceda5ed70ef3 Stream: allow servers with no handler. Previously handlers were mandatory. However

Re: nginx: [emerg] no handler for server in /etc/nginx/nginx.conf:7

2024-06-27 Thread Roman Arutyunyan
.0-2.el9.ngx.src.rpm > From repo: nginx-mainline > Summary : High performance web server > URL : https://nginx.org/ > > -- > Best regards, > Gena > _______ > nginx-ru mailing list > nginx-ru@nginx.org > https://mailman.n

Re: Enable http3 for a subset of domains

2024-06-27 Thread Roman Arutyunyan
Hi, > On 27 Jun 2024, at 10:17 AM, Riccardo Brunetti Host > wrote: > > > >> On 26 Jun 2024, at 17:56, Roman Arutyunyan > <mailto:a...@nginx.com>> wrote: >> >> Hi, >> >>> On 26 Jun 2024, at 7:21 PM, Riccardo Brunetti Host >>

Re: Enable http3 for a subset of domains

2024-06-26 Thread Roman Arutyunyan
Hi, > On 26 Jun 2024, at 7:21 PM, Riccardo Brunetti Host > wrote: > > Hello, thanks for the answer. > >> On 26 Jun 2024, at 16:45, Roman Arutyunyan > <mailto:a...@nginx.com>> wrote: >> >> Hi, >> >>> On 26 Jun 2024, at 6:15 PM,

Re: Enable http3 for a subset of domains

2024-06-26 Thread Roman Arutyunyan
islead clients by offering them to switch to unsupported http/3. > Nginx version: nginx/1.26.1 on ubuntu 22.04 > > Thanks. > Riccardo > ___ > nginx mailing list > nginx@nginx.org > https://mailman.nginx.org/mailman/listinfo/nginx Roman Arutyunyan a...@nginx.com ___ nginx mailing list nginx@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx

[PATCH 2 of 2] Stream: limit SOCK_DGRAM preread to a single datagram

2024-06-07 Thread Roman Arutyunyan
# HG changeset patch # User Roman Arutyunyan # Date 1717774526 -14400 # Fri Jun 07 19:35:26 2024 +0400 # Node ID 231701a85ca1943113f3a3cd9174bd9c9dea1b2f # Parent e2f6f5d01ff6f0dd2e3f0c9328e794af52e65881 Stream: limit SOCK_DGRAM preread to a single datagram. Previously, returning NGX_AGAIN

[PATCH 1 of 2] Stream: removed empty input buffer after peek preread

2024-06-07 Thread Roman Arutyunyan
# HG changeset patch # User Roman Arutyunyan # Date 1717774411 -14400 # Fri Jun 07 19:33:31 2024 +0400 # Node ID e2f6f5d01ff6f0dd2e3f0c9328e794af52e65881 # Parent 02e9411009b987f408214ab4a8b6b6093f843bcd Stream: removed empty input buffer after peek preread. Since peek preread

[PATCH 0 of 2] Stream preread fixes

2024-06-07 Thread Roman Arutyunyan
Stream preread fixes. ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH 2 of 2] Stream: do not reallocate a parsed SNI host

2024-05-30 Thread Roman Arutyunyan
NGX_ERROR; > ___ > nginx-devel mailing list > nginx-devel@nginx.org > https://mailman.nginx.org/mailman/listinfo/nginx-devel -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: merge_slashes

2024-05-30 Thread Roman Arutyunyan
осторожности и анализа возможных последствий. И в этом случае marge_slashes будет работать по-разному в строке запроса и в заголовке Host, что тоже не очень хорошо. > >> On 24 Apr 2024, at 19:24, Roman Arutyunyan wrote: >> >> Добрый день, >> >>> On 16

Re: [PATCH] Proxy: altered limit_rate to support variables

2024-05-27 Thread Roman Arutyunyan
value(conf->upstream.limit_rate, > > + prev->upstream.limit_rate, NULL); > > > > > > ngx_conf_merge_bufs_value(conf->upstream.bufs, prev->upstream.bufs, > > diff -r f366007dd23a -r 98306e705015 s

[nginx] Optimized chain link usage (ticket #2614).

2024-05-27 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/f7d53c7f7014 branches: changeset: 9248:f7d53c7f7014 user: Roman Arutyunyan date: Thu May 23 19:15:38 2024 +0400 description: Optimized chain link usage (ticket #2614). Previously chain links could sometimes be dropped instead of being reused

Re: Inquiry about QUIC Congestion Control Algorithms Development

2024-05-27 Thread Roman Arutyunyan
have CUBIC in our roadmap. BBR will be our next step after it, but no particular plans about it so far. -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: I think I found a fix for the memory leak issue on gRPC module

2024-05-27 Thread Roman Arutyunyan
Hi, Following an internal discussion with Sergey, here's an updated version of the patch. On Thu, May 23, 2024 at 01:42:24PM +0400, Roman Arutyunyan wrote: > Hi, > > On Wed, May 22, 2024 at 06:14:26PM +0400, Roman Arutyunyan wrote: > > Hi, > > > > Indeed there'

Re: I think I found a fix for the memory leak issue on gRPC module

2024-05-23 Thread Roman Arutyunyan
Hi, On Wed, May 22, 2024 at 06:14:26PM +0400, Roman Arutyunyan wrote: > Hi, > > Indeed there's a problem there. We have similar problems in other places as > well. Attached is a patch that fixes all I could find. > > I did some testing for the sub_filter with the follow

Re: I think I found a fix for the memory leak issue on gRPC module

2024-05-22 Thread Roman Arutyunyan
---------- > > Best regards, > Sangmin > ___ > nginx-devel mailing list > nginx-devel@nginx.org > https:/

Re: [patch] reject http header without colon (:) in the header name

2024-05-13 Thread Roman Arutyunyan
.nginx.org/mailman/listinfo/nginx-devel -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

[nginx] Stream pass: disabled passing from or to udp.

2024-05-03 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/89093b003fcb branches: changeset: 9246:89093b003fcb user: Roman Arutyunyan date: Fri May 03 20:26:05 2024 +0400 description: Stream pass: disabled passing from or to udp. Passing from udp was not possible for the most part due to preread

Re: [PATCH] Stream pass: disabled passing from or to udp

2024-05-03 Thread Roman Arutyunyan
Hi, On Fri, May 03, 2024 at 08:24:16PM +0400, Sergey Kandaurov wrote: > > > On 26 Apr 2024, at 15:15, Roman Arutyunyan wrote: > > > > # HG changeset patch > > # User Roman Arutyunyan > > # Date 1714057362 -14400 > > # Thu Apr 25 19:02:42 2024 +0

Re: [PATCH] SSL: fixed possible configuration overwrite loading "engine:" keys

2024-05-03 Thread Roman Arutyunyan
> -*last++ = ':'; > - > pkey = ENGINE_load_private_key(engine, (char *) last, 0, 0); > > if (pkey == NULL) { > ___ > nginx-devel mailing list > nginx-devel@nginx.org > https://mailman.nginx.org/mailman/li

Re: [PATCH]HTTP/2 connection not properly closing during graceful shutdown

2024-04-30 Thread Roman Arutyunyan
Apr 23 17:11:14 2024 +0800 > @@ -304,6 +304,10 @@ > c->idle = 1; > ngx_reusable_connection(c, 0); > > + if (ngx_exiting) { > + c->close = 1; > + } > + > if (c->buffer) { > p = c->buffer->pos; > end = c->buffer->last; This solution allows reading an

Re: headers do not work

2024-04-29 Thread Roman Arutyunyan
uld not abort the request. Please check the error log for the real reason why this is happening. > On Fri, Apr 26, 2024 at 8:20 AM Roman Arutyunyan wrote: > > > > Hi, > > > > > On 25 Apr 2024, at 8:10 AM, Saint Michael wrote: > > > &

Re: headers do not work

2024-04-26 Thread Roman Arutyunyan
ctive (which is also the default) explicitly enables skipping them, and this fact is reported in log. Turn it off and those characters (dot in your case) will pass. --- Roman Arutyunyan a...@nginx.com ___ nginx mailing list nginx@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx

[PATCH] Stream pass: disabled passing from or to udp

2024-04-26 Thread Roman Arutyunyan
# HG changeset patch # User Roman Arutyunyan # Date 1714057362 -14400 # Thu Apr 25 19:02:42 2024 +0400 # Branch stable-1.26 # Node ID a60cd9c99efcc1204e6d395104beb39883308c93 # Parent cdf74ac25b47ec928b53aa82ccc1c3d288a2f81c Stream pass: disabled passing from or to udp. Passing from udp

Re: Leaky NGINX Plugin Advice

2024-04-25 Thread Roman Arutyunyan
; > Many thanks, > Alex > > > ___ > nginx mailing list > ng...@nginx.org <mailto:ng...@nginx.org> > https://mailman.nginx.org/mailman/listinfo/nginx Roman Arutyunyan a...@nginx.com ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: QUIC: use sendmmsg() with GSO

2024-04-25 Thread Roman Arutyunyan
Hi, > On 20 Apr 2024, at 6:12 PM, Marcin Wanat wrote: > > Hi, > > I discovered a patch for QUIC that enables the use of sendmmsg() with > GSO, authored by Roman Arutyunyan: > > https://mailman.nginx.org/pipermail/nginx-devel/2023-July/4ZTXGDMY2LC4VRZRBNBXGULYHS

Re: [PROPOSAL]: Extend list of Stream phases

2024-04-25 Thread Roman Arutyunyan
ith the introduction of ngx_stream_pass_module, you can terminate TLS in one server and then switch to another server for access control. server { listen 9000 ssl; ... pass 127.0.0.1:9001; } server { listen 127.0.0.1:9001; # access control in access phase ... } ---

Re: merge_slashes

2024-04-24 Thread Roman Arutyunyan
> } > > …. много location > > } > > server { > listen *:80; > server_name some.local; > > …. много location > > } > > Best, VS > _______ > ngin

[nginx-announce] nginx-1.26.0

2024-04-23 Thread Roman Arutyunyan
Changes with nginx 1.26.023 Apr 2024 *) 1.26.x stable branch. Roman Arutyunyan a...@nginx.com ___ nginx-announce mailing list nginx-announce@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx

[nginx-ru-announce] nginx-1.26.0

2024-04-23 Thread Roman Arutyunyan
Изменения в nginx 1.26.0 23.04.2024 *) Стабильная ветка 1.26.x. Roman Arutyunyan a...@nginx.com ___ nginx-ru-announce mailing list nginx-ru-announce@nginx.org https://mailman.nginx.org/mailman/listinfo

nginx-1.26.0

2024-04-23 Thread Roman Arutyunyan
Изменения в nginx 1.26.0 23.04.2024 *) Стабильная ветка 1.26.x. Roman Arutyunyan a...@nginx.com ___ nginx-ru mailing list nginx-ru@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-ru

nginx-1.26.0

2024-04-23 Thread Roman Arutyunyan
Changes with nginx 1.26.023 Apr 2024 *) 1.26.x stable branch. Roman Arutyunyan a...@nginx.com ___ nginx mailing list nginx@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx

[nginx] release-1.26.0 tag

2024-04-23 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/cdf74ac25b47 branches: stable-1.26 changeset: 9242:cdf74ac25b47 user: Roman Arutyunyan date: Tue Apr 23 18:04:32 2024 +0400 description: release-1.26.0 tag diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8

[nginx] nginx-1.26.0-RELEASE

2024-04-23 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/a58202a8c41b branches: stable-1.26 changeset: 9241:a58202a8c41b user: Roman Arutyunyan date: Tue Apr 23 17:40:08 2024 +0400 description: nginx-1.26.0-RELEASE diffstat: docs/xml/nginx/changes.xml | 14 ++ 1 files changed, 14

[nginx] Stable branch.

2024-04-23 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/52f427a4c97e branches: stable-1.26 changeset: 9240:52f427a4c97e user: Roman Arutyunyan date: Tue Apr 23 17:31:41 2024 +0400 description: Stable branch. diffstat: src/core/nginx.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions

Re: [PATCH] HTTP/3: fixed handling of malformed request body length

2024-04-23 Thread Roman Arutyunyan
Hi, On Tue, Apr 23, 2024 at 05:14:54PM +0400, Sergey Kandaurov wrote: > > > On 22 Apr 2024, at 19:00, Sergey Kandaurov wrote: > > > > # HG changeset patch > > # User Sergey Kandaurov > > # Date 1713798017 -14400 > > # Mon Apr 22 19:00:17 2024 +0400 > > # Node ID

Re: nginx-1.25.5

2024-04-17 Thread Roman Arutyunyan
entails "directly" in "allows passing the accepted connection > directly to any configured listening socket"? In case of "pass" there's no proxying, hence zero overhead. The connection is passed to the new listening socket li

[nginx-ru-announce] nginx-1.25.5

2024-04-16 Thread Roman Arutyunyan
Sikora. *) Исправление: неожиданное закрытие соединения при использовании 0-RTT в QUIC. Спасибо Владимиру Хомутову. Roman Arutyunyan a...@nginx.com ___ nginx-ru-announce mailing list nginx-ru-announce@nginx.org https

nginx-1.25.5

2024-04-16 Thread Roman Arutyunyan
Sikora. *) Исправление: неожиданное закрытие соединения при использовании 0-RTT в QUIC. Спасибо Владимиру Хомутову. Roman Arutyunyan a...@nginx.com ___ nginx-ru mailing list nginx-ru@nginx.org https://mailman.nginx.org/mailman

[nginx-announce] nginx-1.25.5

2024-04-16 Thread Roman Arutyunyan
rovements. Thanks to Piotr Sikora. *) Bugfix: unexpected connection closure while using 0-RTT in QUIC. Thanks to Vladimir Khomutov. Roman Arutyunyan a...@nginx.com ___ nginx-announce mailing list nginx-announce@nginx.org https://

nginx-1.25.5

2024-04-16 Thread Roman Arutyunyan
rovements. Thanks to Piotr Sikora. *) Bugfix: unexpected connection closure while using 0-RTT in QUIC. Thanks to Vladimir Khomutov. Roman Arutyunyan a...@nginx.com ___ nginx mailing list nginx@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx

[nginx] release-1.25.5 tag

2024-04-16 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/49dce50fad40 branches: changeset: 9239:49dce50fad40 user: Roman Arutyunyan date: Tue Apr 16 18:29:59 2024 +0400 description: release-1.25.5 tag diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8 lines

[nginx] nginx-1.25.5-RELEASE

2024-04-16 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/8618e4d900cc branches: changeset: 9238:8618e4d900cc user: Roman Arutyunyan date: Tue Apr 16 18:27:50 2024 +0400 description: nginx-1.25.5-RELEASE diffstat: docs/xml/nginx/changes.xml | 77 ++ 1

[nginx] Stream pass: limited the number of passes per connection.

2024-04-11 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/9f84f2e49c62 branches: changeset: 9237:9f84f2e49c62 user: Roman Arutyunyan date: Thu Apr 11 11:37:30 2024 +0400 description: Stream pass: limited the number of passes per connection. Previously a cycle in pass configuration resulted in stack

Re: [nginx] QUIC: "handshake_timeout" configuration parameter.

2024-04-10 Thread Roman Arutyunyan
Hi, > On 10 Apr 2024, at 10:57 AM, Vladimir Homutov wrote: > > On Tue, Apr 09, 2024 at 03:02:21PM +0400, Roman Arutyunyan wrote: >> Hello Vladimir, >> >> On Mon, Apr 08, 2024 at 03:03:27PM +0300, Vladimir Homutov via nginx-devel >> wrote: >>> On Fr

[nginx] QUIC: fixed close timer processing with early data.

2024-04-10 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/155c9093de9d branches: changeset: 9236:155c9093de9d user: Vladimir Khomutov date: Wed Apr 10 09:38:10 2024 +0300 description: QUIC: fixed close timer processing with early data. The ngx_quic_run() function uses qc->close timer to limit the

Re: [nginx] QUIC: "handshake_timeout" configuration parameter.

2024-04-09 Thread Roman Arutyunyan
Hello Vladimir, On Mon, Apr 08, 2024 at 03:03:27PM +0300, Vladimir Homutov via nginx-devel wrote: > On Fri, Sep 22, 2023 at 03:36:25PM +0000, Roman Arutyunyan wrote: > > details: https://hg.nginx.org/nginx/rev/ad3d34ddfdcc > > branches: > > changeset: 9158:ad3d34ddfdcc

Re: [PATCH] Detecting duplicate addresses in listen among different modules

2024-04-08 Thread Roman Arutyunyan
I like the idea of fixing address collisions between modules. However, the patch does not fix the problem entirely and leaves room for misconfigurations. IMHO we need to think how to properly fix this. One way for fixing this is rejecting any overlapping listen addresses. We need to evaluate how likely it is that reasonable configurations will be restricted by this. It doesn't seem likely to me. Roman Arutyunyan a...@nginx.com ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Stream: $server_name

2024-03-23 Thread Roman Arutyunyan
Hi, On Fri, Mar 22, 2024 at 06:41:12PM +0400, Sergey Kandaurov wrote: > # HG changeset patch > # User Sergey Kandaurov > # Date 178390 -14400 > # Fri Mar 22 18:39:50 2024 +0400 > # Node ID 96ff3f8b7e508a345c18bb1e1071f248f1e5a75c > # Parent 6317e21a15e083a215b52480b8ef473fdfe34158 >

Re: [PATCH] Avoiding mixed socket families in PROXY protocol v1 (ticket #2594)

2024-03-21 Thread Roman Arutyunyan
Hi, On Wed, Mar 13, 2024 at 09:08:43PM +0400, Sergey Kandaurov wrote: > On Mon, Mar 11, 2024 at 04:44:15PM +0400, Roman Arutyunyan wrote: > > Hi, > > > > On Wed, Mar 06, 2024 at 06:50:26PM +0400, Sergey Kandaurov wrote: > > > On Thu, Feb 22, 2024 at 07:17:26PM

[nginx] Stream: ngx_stream_pass_module.

2024-03-21 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/913518341c20 branches: changeset: 9217:913518341c20 user: Roman Arutyunyan date: Wed Feb 21 17:36:02 2024 +0400 description: Stream: ngx_stream_pass_module. The module allows to pass connections from Stream to other modules such as HTTP

[nginx] Stream: virtual servers.

2024-03-21 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/e28b044908cb branches: changeset: 9216:e28b044908cb user: Roman Arutyunyan date: Thu Dec 14 21:58:39 2023 +0400 description: Stream: virtual servers. Server name is taken either from ngx_stream_ssl_module or ngx_stream_ssl_preread_module

[nginx] Stream: socket peek in preread phase.

2024-03-21 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/cf890df37bb6 branches: changeset: 9215:cf890df37bb6 user: Roman Arutyunyan date: Wed Dec 13 18:04:55 2023 +0400 description: Stream: socket peek in preread phase. Previously, preread buffer was always read out from socket, which made

[nginx] Version bump.

2024-03-21 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/d6f8a2c31cde branches: changeset: 9214:d6f8a2c31cde user: Roman Arutyunyan date: Thu Mar 21 17:06:21 2024 +0400 description: Version bump. diffstat: src/core/nginx.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diffs (14

Re: [PATCH 1 of 2] SSL: add support for AWS-LC

2024-03-18 Thread Roman Arutyunyan
|| defined OPENSSL_IS_AWSLC > \ > || defined LIBRESSL_VERSION_NUMBER > \ > || NGX_QUIC_OPENSSL_COMPAT > #define NGX_QUIC_BORINGSSL_API 1 > @@ -578,7 +579,7 @@ > return NGX_ERROR; > } > > -#ifdef OPENSSL_IS_BORINGSSL > +#if defined(OPENSSL_IS_BORINGSSL) || defined(OPENSSL_IS_AWSLC) > if (SSL_set_quic_early_data_context(ssl_conn, p, clen) == 0) { > ngx_log_error(NGX_LOG_INFO, c->log, 0, >"quic SSL_set_quic_early_data_context() failed"); It looks like this library is not super popular, but the patch is relatively large. Also, compiling nginx with -DOPENSSL_IS_BORINGSSL should probably solve the issue. -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Core: fix build without libcrypt

2024-03-18 Thread Roman Arutyunyan
+ngx_libc_crypt(ngx_pool_t *pool, u_char *key, u_char *salt, u_char > **encrypted) > +{ > +return NGX_ERROR; > +} > + > #endif > > #endif /* NGX_CRYPT */ > ___ > nginx-devel mailing list > nginx-devel@nginx.org > https://mailman.nginx.org/mailman/listinfo/nginx-devel -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Geo: fix uninitialized memory access

2024-03-14 Thread Roman Arutyunyan
r need to explicitly initialize fields to zero. Also, I think we need more details about the uninitialized memory access. See updated patch. -- Roman Arutyunyan # HG changeset patch # User Piotr Sikora # Date 1710427040 -14400 # Thu Mar 14 18:37:20 2024 +0400 # Node ID bd1

Re: auth_request module is sending the auth subrequest twice

2024-03-11 Thread Roman Arutyunyan
ength ""; > > proxy_set_headerX-Original-URI $request_uri; > > } > > > > location @error401 { > > return 302 /login; > > } > > > > #error_page 404

Re: [PATCH] Avoiding mixed socket families in PROXY protocol v1 (ticket #2594)

2024-03-11 Thread Roman Arutyunyan
Hi, On Wed, Mar 06, 2024 at 06:50:26PM +0400, Sergey Kandaurov wrote: > On Thu, Feb 22, 2024 at 07:17:26PM +0400, Roman Arutyunyan wrote: > > Hi, > > > > On Thu, Feb 22, 2024 at 01:59:25AM +, J Carter wrote: > > > Hello Roman, > > > > > >

[PATCH 2 of 2] QUIC: input packet batching with recvmmsg()

2024-03-07 Thread Roman Arutyunyan
# HG changeset patch # User Roman Arutyunyan # Date 1707486707 -28800 # Fri Feb 09 21:51:47 2024 +0800 # Node ID 4584ba4b1d65a90f69201cecf1f1e650c1cbd87b # Parent 5d28510b62bffba3187d7fe69baccd2d2da41a12 QUIC: input packet batching with recvmmsg(). diff --git a/auto/os/linux b/auto/os

[PATCH 1 of 2] QUIC: output packet batching with sendmmsg()

2024-03-07 Thread Roman Arutyunyan
# HG changeset patch # User Roman Arutyunyan # Date 1709833123 -28800 # Fri Mar 08 01:38:43 2024 +0800 # Node ID 5d28510b62bffba3187d7fe69baccd2d2da41a12 # Parent 2ed3f57dca0a664340bca2236c7d614902db4180 QUIC: output packet batching with sendmmsg(). diff --git a/auto/os/linux b/auto/os

[PATCH 0 of 2] QUIC packet batching on Linux

2024-03-07 Thread Roman Arutyunyan
, but the testing is still ongoing. -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Configure: add support for Homebrew on Apple Silicon

2024-03-06 Thread Roman Arutyunyan
ngx_feature="PCRE library in /opt/homebrew/" > +ngx_feature_path="/opt/homebrew/include" > + > +if [ $NGX_RPATH = YES ]; then > +ngx_feature_libs="-R/opt/homebrew/lib -L/opt/homebrew/lib &

Re: [PATCH] Fixed 413 custom error page for HTTP/2 and HTTP/3 (ticket #2609)

2024-03-05 Thread Roman Arutyunyan
Hi Maxim, > On 6 Mar 2024, at 12:28 AM, Maxim Dounin wrote: > > Hello! > > On Mon, Mar 04, 2024 at 06:46:23PM +0400, Roman Arutyunyan wrote: > >> # HG changeset patch >> # User Roman Arutyunyan >> # Date 1709563405 -14400 >> # M

[PATCH] Fixed 413 custom error page for HTTP/2 and HTTP/3 (ticket #2609)

2024-03-04 Thread Roman Arutyunyan
# HG changeset patch # User Roman Arutyunyan # Date 1709563405 -14400 # Mon Mar 04 18:43:25 2024 +0400 # Node ID 3b0be477ab7246caba4c5152286b8be520ee0418 # Parent 44da04c2d4db94ad4eefa84b299e07c5fa4a00b9 Fixed 413 custom error page for HTTP/2 and HTTP/3 (ticket #2609). Previously

Re: [PATCH 3 of 3] Stream: ngx_stream_pass_module

2024-02-28 Thread Roman Arutyunyan
Hi, On Wed, Feb 28, 2024 at 02:15:40PM +0400, Sergey Kandaurov wrote: > On Wed, Feb 21, 2024 at 05:37:51PM +0400, Roman Arutyunyan wrote: > > Hi, > > > > On Tue, Feb 13, 2024 at 02:46:35PM +0400, Sergey Kandaurov wrote: > > > > > > > On 10 N

Re: nginx-devel Digest, Vol 162, Issue 26

2024-02-26 Thread Roman Arutyunyan
w...@nginx.org > > > > When replying, please edit your Subject line so it is more specific > > than "Re: Contents of nginx-devel digest..." > > > > > > Today's Topics: > > > >1. Re: Inquiry Regarding Handling of QUIC Connections During > > Ngi

Re: Inquiry Regarding Handling of QUIC Connections During Nginx Reload

2024-02-26 Thread Roman Arutyunyan
nt sockets using --without-quic_client_sockets. Otherwise just apply the first 3 patches. Here's a relevant trac ticket: https://trac.nginx.org/nginx/ticket/2528 -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Avoiding mixed socket families in PROXY protocol v1 (ticket #2594)

2024-02-22 Thread Roman Arutyunyan
Hi, On Thu, Feb 22, 2024 at 01:59:25AM +, J Carter wrote: > Hello Roman, > > On Wed, 21 Feb 2024 17:29:52 +0400 > Roman Arutyunyan wrote: > > > Hi, > > > > [...] > > > Checking whether the address used in PROXY writer is in fact the addre

Re: [PATCH 3 of 3] Stream: ngx_stream_pass_module

2024-02-21 Thread Roman Arutyunyan
Hi, On Tue, Feb 13, 2024 at 02:46:35PM +0400, Sergey Kandaurov wrote: > > > On 10 Nov 2023, at 14:07, Roman Arutyunyan wrote: > > > > # HG changeset patch > > # User Roman Arutyunyan > > # Date 1699543504 -14400 > > # Thu N

Re: [PATCH] Avoiding mixed socket families in PROXY protocol v1 (ticket #2594)

2024-02-21 Thread Roman Arutyunyan
Hi, On Wed, Jan 24, 2024 at 12:03:06AM +0300, Maxim Dounin wrote: > Hello! > > On Mon, Jan 22, 2024 at 07:48:01PM +0400, Roman Arutyunyan wrote: > > > Hi, > > > > On Mon, Jan 22, 2024 at 02:59:21PM +0300, Maxim Dounin wrote: > > > Hello! > > >

Re: Issues building Nginx using boringssl

2024-02-20 Thread Roman Arutyunyan
ssl.{a|so}. Those artifacts are usually > > placed in a lib/ directory, not in separate ssl/ and crypto/ > > directories. (Two separate directories may be a BoringSSL-ism). > > > > So I believe the proper flag would be similar to: > > > > --with-ld-op

Re: NGINX Reverse Proxy terminate TCP connection after 5 minutes of inactivity

2024-02-19 Thread Roman Arutyunyan
ve related parameters as per the nginx config > above and also check on the OS's TCP tunable and i could not find any > related settings which make NGINX to kill the TCP connection. > > Anyone encountering the same issues? > ___ > nginx mailing list > nginx@nginx.org > https://mailman.nginx.org/mailman/listinfo/nginx -- Roman Arutyunyan ___ nginx mailing list nginx@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx

Re: announcing freenginx.org

2024-02-15 Thread Roman Arutyunyan
but to open source software and the Internet itself. We wish you the best of luck and would be pleased to work with you again in future. -- Roman Arutyunyan ___ nginx mailing list nginx@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx

[nginx] QUIC: fixed unsent MTU probe acknowledgement.

2024-02-14 Thread Roman Arutyunyan
details: https://hg.nginx.org/nginx/rev/2ed3f57dca0a branches: changeset: 9208:2ed3f57dca0a user: Roman Arutyunyan date: Wed Feb 14 16:56:28 2024 +0400 description: QUIC: fixed unsent MTU probe acknowledgement. Previously if an MTU probe send failed early in ngx_quic_frame_sendto

Re: [PATCH] QUIC: fixed unsent MTU probe acknowledgement

2024-02-14 Thread Roman Arutyunyan
Hi, On Tue, Feb 13, 2024 at 04:54:24PM +0400, Sergey Kandaurov wrote: > > > On 9 Feb 2024, at 13:56, Roman Arutyunyan wrote: > > > > # HG changeset patch > > # User Roman Arutyunyan > > # Date 1707472496 -14400 > > # Fri F

Re: ngx_http_v3_init_session function

2024-02-09 Thread Roman Arutyunyan
/src/http/modules/ngx_http_ssl_module.c As you see in ngx_http_ssl_servername() code, it already assumes that c->data references a ngx_http_connection_t object, so can you. > Regards, > Gabriel > > On Wed, Feb 7, 2024 at 11:29 AM Roman Arutyunyan wrote: > > > Hi, >

[PATCH] QUIC: fixed unsent MTU probe acknowledgement

2024-02-09 Thread Roman Arutyunyan
# HG changeset patch # User Roman Arutyunyan # Date 1707472496 -14400 # Fri Feb 09 13:54:56 2024 +0400 # Node ID 9b89f44ddd3637afc939e31de348c7986ae9e76d # Parent 73eb75bee30f4aee66edfb500270dbb14710aafd QUIC: fixed unsent MTU probe acknowledgement. Previously if an MTU probe send failed

Re: ngx_http_v3_init_session function

2024-02-07 Thread Roman Arutyunyan
1 as well. You need to know what's the current connection stage to tell this. ngx_http_v3_init_session() is called right before initializing QUIC streams for the session. When exactly do you call your function? [..] -- Roman Arutyunyan ___ nginx mailing list nginx@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx

Re: Segfault when interpreting cached X-Accel-Redirect response

2024-02-02 Thread Roman Arutyunyan
if (rc == NGX_DECLINED) { > +return; > +} > + > ngx_http_finalize_request(r, NGX_DONE); > return; > } > ___ > nginx-devel mailing list > nginx-devel@nginx.org > https://mailman.nginx.org/mailman/listinfo/nginx-devel The patch seems ok, but needs to be tested. -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH 1 of 4] Fixed request termination with AIO and subrequests (ticket #2555)

2024-01-29 Thread Roman Arutyunyan
Hi, On Mon, Jan 29, 2024 at 10:58:09AM +0300, Maxim Dounin wrote: > Hello! > > On Fri, Jan 26, 2024 at 04:02:30PM +0400, Roman Arutyunyan wrote: > > > On Mon, Nov 27, 2023 at 05:50:24AM +0300, Maxim Dounin wrote: > > > # HG changeset patch > > > # User M

Re: [PATCH 1 of 4] Fixed request termination with AIO and subrequests (ticket #2555)

2024-01-26 Thread Roman Arutyunyan
Hi, On Mon, Nov 27, 2023 at 05:50:24AM +0300, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1701049682 -10800 > # Mon Nov 27 04:48:02 2023 +0300 > # Node ID a5e39e9d1f4c84dcbe6a2f9e079372a3d63aef0b > # Parent f366007dd23a6ce8e8427c1b3042781b618a2ade > Fixed

Re: [PATCH] Introduced worker_shutdown_idle_delay

2024-01-25 Thread Roman Arutyunyan
thus > increase nginx resource usage), and ideally in combination with properly > configured clients: [..] I suggest a simpler patch which disables idle mode for HTTP keepalive connections. Such connections will not be closed until one of the timeouts (keepalive_timeout or worker_shutdown

Re: [PATCH] Avoiding mixed socket families in PROXY protocol v1 (ticket #2594)

2024-01-22 Thread Roman Arutyunyan
Hi, On Mon, Jan 22, 2024 at 02:59:21PM +0300, Maxim Dounin wrote: > Hello! > > On Mon, Jan 22, 2024 at 02:49:54PM +0400, Roman Arutyunyan wrote: > > > # HG changeset patch > > # User Roman Arutyunyan > > # Date 1705916128 -14400 > > # Mon Jan

  1   2   3   4   5   6   7   8   9   10   >