Re: proxy_pass redirect for address without trailing slash disregards Host port

2019-08-30 Thread Francis Daly
On Sat, Aug 24, 2019 at 11:17:34AM +0200, Nuno Gonçalves wrote: Hi there, > That's not correct, the server is taking the Host domain part from the > client Host header. It's just not taking the port part. > > This inconsistency is why I believe it's a bug. Before "absolute_redirect", I would ha

Re: proxy_pass redirect for address without trailing slash disregards Host port

2019-08-24 Thread Jeffrey 'jf' Lim
On Sat, Aug 24, 2019 at 9:32 PM Jeffrey 'jf' Lim wrote: > > On Sat, Aug 24, 2019 at 5:18 PM Nuno Gonçalves wrote: > > > > On Sat, Aug 24, 2019 at 8:24 AM Jeffrey 'jf' Lim > > wrote: > > > > > > The host is defined by the server, surely, and not by what the client > > > tells the server it is?

Re: proxy_pass redirect for address without trailing slash disregards Host port

2019-08-24 Thread Nuno Gonçalves
On Sat, Aug 24, 2019 at 3:33 PM Jeffrey 'jf' Lim wrote: > When you say that "only the absolute redirect is affected by this > issue", I assume you mean that absolute redirects are affected > *because* they specify the hostname (and indirectly, the port), vs > relative redirects don't? Yes. __

Re: proxy_pass redirect for address without trailing slash disregards Host port

2019-08-24 Thread Jeffrey 'jf' Lim
On Sat, Aug 24, 2019 at 5:18 PM Nuno Gonçalves wrote: > > On Sat, Aug 24, 2019 at 8:24 AM Jeffrey 'jf' Lim wrote: > > > > The host is defined by the server, surely, and not by what the client tells > > the server it is? And you tell the server what host it is by the > > server_name directive >

Re: proxy_pass redirect for address without trailing slash disregards Host port

2019-08-24 Thread Nuno Gonçalves
On Sat, Aug 24, 2019 at 8:24 AM Jeffrey 'jf' Lim wrote: > > The host is defined by the server, surely, and not by what the client tells > the server it is? And you tell the server what host it is by the server_name > directive > (https://nginx.org/en/docs/http/ngx_http_core_module.html#server_n

Re: proxy_pass redirect for address without trailing slash disregards Host port

2019-08-23 Thread Jeffrey 'jf' Lim
The host is defined by the server, surely, and not by what the client tells the server it is? And you tell the server what host it is by the server_name directive ( https://nginx.org/en/docs/http/ngx_http_core_module.html#server_name). -jf On Sat, 24 Aug 2019, 01:39 Nuno Gonçalves, wrote: > I a

proxy_pass redirect for address without trailing slash disregards Host port

2019-08-23 Thread Nuno Gonçalves
I am using proxy_pass and I'm facing a issue which I'm not sure it's a bug. It is in regard to the behaviour specified by the documentation [1]: If a location is defined by a prefix string that ends with the slash character, and requests are processed by one of proxy_pass, fastcgi_pass, uwsgi_pas