Some comments received on the patch from Filipe
I can add that I think your patch is valuable.
But half of the changes are not related to the main patch goals:
- expected args count check
- additional error messages.
Just a quick review of your patch:
- it is too long to be easily reviewed.
- pl
details: http://hg.nginx.org/nginx/rev/102f85699420
branches:
changeset: 5863:102f85699420
user: Valentin Bartenev
date: Wed Sep 24 21:55:19 2014 +0400
description:
Limit req: reduced number of parameters in the lookup function.
No functional changes.
diffstat:
src/http/modules/n
details: http://hg.nginx.org/nginx/rev/c9787372f16d
branches:
changeset: 5860:c9787372f16d
user: Valentin Bartenev
date: Wed Sep 24 21:55:19 2014 +0400
description:
Limit conn: use complex value in limit_conn_zone (ticket #121).
One intentional side effect of this change is that key
details: http://hg.nginx.org/nginx/rev/ecbb99aa0e12
branches:
changeset: 5862:ecbb99aa0e12
user: Valentin Bartenev
date: Wed Sep 24 21:55:19 2014 +0400
description:
Limit req: use complex value in limit_req_zone.
One intentional side effect of this change is that key is allowed only
details: http://hg.nginx.org/nginx/rev/1e6bf87a7289
branches:
changeset: 5861:1e6bf87a7289
user: Valentin Bartenev
date: Wed Sep 24 21:55:19 2014 +0400
description:
Limit conn: aligned field names in structures.
No functional changes.
diffstat:
src/http/modules/ngx_http_limit_con
details: http://hg.nginx.org/nginx/rev/02c2352d5b01
branches:
changeset: 5858:02c2352d5b01
user: Vladimir Homutov
date: Tue Aug 26 14:56:54 2014 +0400
description:
Syslog: improved error handling of unix domain sockets.
If a syslog daemon is restarted and the unix socket is used, fu
details: http://hg.nginx.org/nginx/rev/2cb5275bf5e7
branches:
changeset: 5857:2cb5275bf5e7
user: Vladimir Homutov
date: Mon Sep 01 17:55:07 2014 +0400
description:
Syslog: enabled logging of send errors.
The ngx_cycle->log is used when sending the message. This allows to log syslog
