Re: Proposed changeset to fix client cert from ngx_ssl_get_certificate passed as HTTP header value

2016-02-05 Thread Maxim Dounin
Hello! On Thu, Feb 04, 2016 at 01:38:48PM -0800, Sam McKelvie wrote: > I think it is your call if you want to make a breaking change to > $ssl_client_cert to URL encode it; I'd be happy to submit the > changeset if you would approve that, but I personally don't feel > comfortable breaking any exi

Re: [nginx] Dynamic modules.

2016-02-05 Thread Maxim Dounin
Hello! On Fri, Feb 05, 2016 at 01:16:51PM +, Daniel K. wrote: > On 02/05/2016 12:52 PM, Maxim Dounin wrote: > > The > > > > details: http://hg.nginx.org/nginx/rev/85dea406e18f > > > > line at the top of the message contains link to the full changeset > > if you want to read all the detai

Re: [nginx] Dynamic modules.

2016-02-05 Thread Daniel K.
On 02/05/2016 12:52 PM, Maxim Dounin wrote: > The > > details: http://hg.nginx.org/nginx/rev/85dea406e18f > > line at the top of the message contains link to the full changeset > if you want to read all the details. I know, but why send out anything other than the metadata if the diff may be

Re: [nginx] Dynamic modules.

2016-02-05 Thread Maxim Dounin
Hello! On Fri, Feb 05, 2016 at 11:30:17AM +, Daniel K. wrote: > On 02/04/2016 06:40 PM, Maxim Dounin wrote: > > Dynamic modules. > > > > diffstat: > > > > [...] > > 21 files changed, 1136 insertions(+), 34 deletions(-) > > Thanks for posting your work on dynamic modules, but the followin

RE: [nginx] Dynamic modules.

2016-02-05 Thread Lukas Tribus
>> diffs (truncated from 1720 to 300 lines): > > makes this and other mail in the series a bit useless. You are supposed to checkout the mercury repository, not apply committed patches from the dev list manually if they are committed anyway. Just clone it: hg clone http://hg.nginx.org/nginx and

Re: [nginx] Dynamic modules.

2016-02-05 Thread Daniel K.
On 02/04/2016 06:40 PM, Maxim Dounin wrote: > Dynamic modules. > > diffstat: > > [...] > 21 files changed, 1136 insertions(+), 34 deletions(-) Thanks for posting your work on dynamic modules, but the following > diffs (truncated from 1720 to 300 lines): makes this and other mail in the serie

[nginx] Dynamic modules: fixed a copy-n-paste error.

2016-02-05 Thread Ruslan Ermilov
details: http://hg.nginx.org/nginx/rev/e0d7c2f71851 branches: changeset: 6384:e0d7c2f71851 user: Ruslan Ermilov date: Fri Feb 05 14:02:54 2016 +0300 description: Dynamic modules: fixed a copy-n-paste error. diffstat: auto/modules | 2 +- 1 files changed, 1 insertions(+), 1 deleti