[njs] Using short string values where they are enough.

details: http://hg.nginx.org/njs/rev/f8f20b27724e branches: changeset: 270:f8f20b27724e user: Igor Sysoev date: Thu Dec 01 19:45:19 2016 +0300 description: Using short string values where they are enough. diffstat: njs/njs_date.c | 28

Re: Why not remove UNIX domain socket before bind

Hello! On Thu, Dec 01, 2016 at 01:20:43AM -0800, Alexey Ivanov wrote: > Why not just use `flock(2)` there? It won't work if the socket is used by a different server. -- Maxim Dounin http://nginx.org/ ___ nginx-devel mailing list

[nginx] Events: improved error event handling for UDP sockets.

details: http://hg.nginx.org/nginx/rev/75dbab4ea930 branches: changeset: 6806:75dbab4ea930 user: Dmitry Volyntsev date: Mon Nov 21 16:03:42 2016 +0300 description: Events: improved error event handling for UDP sockets. Normally, the epoll module calls the read and

Re: Why not remove UNIX domain socket before bind

Why not just use `flock(2)` there? > On Nov 30, 2016, at 6:57 AM, Maxim Dounin wrote: > > Hello! > > On Tue, Nov 29, 2016 at 01:30:25PM -0800, Shuxin Yang wrote: > >> Is there any reason not to delete UNIX domain socket before bind? > > To name a few, deleting a

Re: Why not remove UNIX domain socket before bind

Hi Maxim, Thanks for the explanation. Regarding a), what about checking and making sure the type of file is actually a socket before removing? Obviously it does not prevent NGINX from deleting sockets created by other processes but it's a much smaller issue compared to deleting arbitrary file.