Re: [PATCH] HTTP/2: reject HTTP/2 requests without ":scheme" pseudo-header

2017-03-27 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:17 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516708 25200 > # Sun Mar 26 01:25:08 2017 -0700 > # Node ID 6bb029b1df11662ba11e190490cf1ed175fcfaa6 > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: re

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid ENABLE_PUSH setting value

2017-03-27 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:16 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516707 25200 > # Sun Mar 26 01:25:07 2017 -0700 > # Node ID 705897a463205ba00dce296ff49866c6b78fc6ee > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: em

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

2017-03-27 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:15 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516706 25200 > # Sun Mar 26 01:25:06 2017 -0700 > # Node ID 9bbcacbdf6bd858a34a9dfd1ac2185eb8fc8c82f > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: em

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on padding errors

2017-03-27 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:13 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516705 25200 > # Sun Mar 26 01:25:05 2017 -0700 > # Node ID 8d3fb456411018e286345ba92a855ca42ca8af2f > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: em

Re: [PATCH] HTTP/2: fix flow control with padded DATA frames

2017-03-27 Thread Piotr Sikora via nginx-devel
Hey Valentin, >> @@ -802,33 +805,32 @@ ngx_http_v2_state_data(ngx_http_v2_conne >> } >> >> h2c->state.padding = *pos++; >> -h2c->state.length--; >> - >> -if (h2c->state.padding > h2c->state.length) { >> + >> +if (h2c->state.padding >= size) { >>

Re: [PATCH] HTTP/2: fix flow control with padded DATA frames

2017-03-27 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:11 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516704 25200 > # Sun Mar 26 01:25:04 2017 -0700 > # Node ID 899a53d2789b8c6bafdd5e40d78b4e92dd32dd10 > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: fi

Re: [bugfix] Mp4: set single_range when ngx_http_mp4_process()returnsNGX_OK.

2017-03-27 Thread 胡聪 (hucc)
Hi, On Tuesday, Mar 28, 2017 0:38 AM +0300, Maxim Dounin wrote: >The problem here is consistency and predictability from user point >of view as well. If nginx can handle multi-range requests in some >cases, but not in others, it creates a huge problem for anyone who >is trying to understand w

Re: [PATCH 2 of 2] HTTP/2: fix $body_bytes_sent variable

2017-03-27 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:10 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516703 25200 > # Sun Mar 26 01:25:03 2017 -0700 > # Node ID dd6c656ed7a327641b2ddfc34768f9551e44bb0f > # Parent 74ee816e712ee3b731437947470383555653338d > HTTP/2: fi

Re: [PATCH 1 of 2] HTTP/2: fix $bytes_sent variable

2017-03-27 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:09 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516702 25200 > # Sun Mar 26 01:25:02 2017 -0700 > # Node ID 74ee816e712ee3b731437947470383555653338d > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: fi

Re: [bugfix] Mp4: fixed start time is out mp4 mdat atom.

2017-03-27 Thread 胡聪 (hucc)
Hi, On Monday, Mar 27, 2017 11:39 PM +0300, Maxim Dounin wrote: >On Mon, Mar 27, 2017 at 10:57:51PM +0800, 胡聪 (hucc) wrote: > >> # HG changeset patch >> # User hucongcong >> # Date 1490619789 -28800 >> # Mon Mar 27 21:03:09 2017 +0800 >> # Node ID 67ad0b01f77ea5590d390b4b38d71ec2c739d333 >>

Re: [bugfix] Mp4: set single_range when ngx_http_mp4_process()returns NGX_OK.

2017-03-27 Thread Maxim Dounin
Hello! On Tue, Mar 28, 2017 at 12:18:13AM +0800, 胡聪 (hucc) wrote: > On Monday, Mar 27, 2017 11:31 PM +0300, Maxim Dounin wrote: > > >What's the goal of this patch? > >Do you want mp4 to handle multi-range requests? Have you ever > >seen clients doing such requests? > > yes, I want mp4 to hand

Re: [bugfix] Mp4: set single_range when ngx_http_mp4_process()returns NGX_OK.

2017-03-27 Thread 胡聪 (hucc)
Hi, On Monday, Mar 27, 2017 11:31 PM +0300, Maxim Dounin wrote: >What's the goal of this patch? >Do you want mp4 to handle multi-range requests? Have you ever >seen clients doing such requests? yes, I want mp4 to handle multi-range requests is that case. If it can do it, why not? In addition,

Re: [bugfix] Mp4: fixed start time is out mp4 mdat atom.

2017-03-27 Thread Maxim Dounin
Hello! On Mon, Mar 27, 2017 at 10:57:51PM +0800, 胡聪 (hucc) wrote: > # HG changeset patch > # User hucongcong > # Date 1490619789 -28800 > # Mon Mar 27 21:03:09 2017 +0800 > # Node ID 67ad0b01f77ea5590d390b4b38d71ec2c739d333 > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > Mp4: fixed s

Re: [bugfix] Mp4: set single_range when ngx_http_mp4_process() returns NGX_OK.

2017-03-27 Thread Maxim Dounin
Hello! On Mon, Mar 27, 2017 at 10:56:13PM +0800, 胡聪 (hucc) wrote: > # HG changeset patch > # User hucongcong > # Date 1490618655 -28800 > # Mon Mar 27 20:44:15 2017 +0800 > # Node ID 84d73e16113e3fccea9a0156f8edb8e8d0e7499a > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > Mp4: set sin

[bugfix] Mp4: fixed start time is out mp4 mdat atom.

2017-03-27 Thread 胡聪 (hucc)
# HG changeset patch # User hucongcong # Date 1490619789 -28800 # Mon Mar 27 21:03:09 2017 +0800 # Node ID 67ad0b01f77ea5590d390b4b38d71ec2c739d333 # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 Mp4: fixed start time is out mp4 mdat atom. start time is already out mp4 mdat atom when star

[bugfix] Mp4: set single_range when ngx_http_mp4_process() returns NGX_OK.

2017-03-27 Thread 胡聪 (hucc)
# HG changeset patch # User hucongcong # Date 1490618655 -28800 # Mon Mar 27 20:44:15 2017 +0800 # Node ID 84d73e16113e3fccea9a0156f8edb8e8d0e7499a # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 Mp4: set single_range when ngx_http_mp4_process() returns NGX_OK. Set single_range flag in re