Re: [PATCH] HTTP/2: add fast-path for HTTP/2 requests without request body

2017-03-28 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:23 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516712 25200 > # Sun Mar 26 01:25:12 2017 -0700 > # Node ID f9fd6a8babce9f57f038d304dc1eef82284dde8b > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: ad

Re: [PATCH] HTTP/2: reject HTTP/2 requests without ":scheme" pseudo-header

2017-03-28 Thread Valentin V. Bartenev
On Tuesday 28 March 2017 05:40:44 Piotr Sikora via nginx-devel wrote: > Hey Valentin, > > > This part of patch can be added to the style one: > > > > "HTTP/2: style and typos." > > Assuming that this patch gets dropped or even if it gets committed? > IMHO it's not a good idea to combine style

Re: [PATCH] HTTP/2: add logging of RST_STREAM frames with NO_ERROR code

2017-03-28 Thread Valentin V. Bartenev
On Sunday 26 March 2017 01:41:20 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516710 25200 > # Sun Mar 26 01:25:10 2017 -0700 > # Node ID 31dfcde3ea2ccf1a2dbd2601ebe8f4306887fc0f > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: ad

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

2017-03-28 Thread Valentin V. Bartenev
On Tuesday 28 March 2017 03:52:07 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516706 25200 > # Sun Mar 26 01:25:06 2017 -0700 > # Node ID ccb36c87291e38d1a63224d143cbeaa4ee4a4287 > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: e

[nginx] Copy filter: wake up subrequests after aio operations.

2017-03-28 Thread Maxim Dounin
details: http://hg.nginx.org/nginx/rev/ce37362a7a70 branches: changeset: 6951:ce37362a7a70 user: Maxim Dounin date: Tue Mar 28 18:15:42 2017 +0300 description: Copy filter: wake up subrequests after aio operations. Previously, connection write handler was called, resulting in wake u

[nginx] Threads: fixed request hang with aio_write and subrequests.

2017-03-28 Thread Maxim Dounin
details: http://hg.nginx.org/nginx/rev/4cb4ffe06785 branches: changeset: 6950:4cb4ffe06785 user: Maxim Dounin date: Tue Mar 28 18:15:41 2017 +0300 description: Threads: fixed request hang with aio_write and subrequests. If the subrequest is already finalized, the handler set with ai

[nginx] Simplified and improved sendfile() code on Linux.

2017-03-28 Thread Maxim Dounin
details: http://hg.nginx.org/nginx/rev/ff0c8e11edbc branches: changeset: 6949:ff0c8e11edbc user: Maxim Dounin date: Tue Mar 28 18:15:39 2017 +0300 description: Simplified and improved sendfile() code on Linux. The ngx_linux_sendfile() function is now used for both normal sendfile()

[njs] The njs_vm_trap_value() macro.

2017-03-28 Thread Igor Sysoev
details: http://hg.nginx.org/njs/rev/8e1030bce13c branches: changeset: 319:8e1030bce13c user: Igor Sysoev date: Tue Mar 21 16:35:36 2017 +0300 description: The njs_vm_trap_value() macro. diffstat: njs/njs_array.c| 4 ++-- njs/njs_date.c | 4 ++-- njs/njs_function.h | 5

[njs] The njs_vm_continuation() macro.

2017-03-28 Thread Igor Sysoev
details: http://hg.nginx.org/njs/rev/705129b55888 branches: changeset: 318:705129b55888 user: Igor Sysoev date: Tue Mar 21 16:35:22 2017 +0300 description: The njs_vm_continuation() macro. diffstat: njs/njs_array.c| 42 +- njs/njs_date.

[njs] Closures support.

2017-03-28 Thread Igor Sysoev
details: http://hg.nginx.org/njs/rev/a095dc0cd361 branches: changeset: 321:a095dc0cd361 user: Igor Sysoev date: Tue Mar 28 07:50:05 2017 +0300 description: Closures support. diffstat: njs/njs_array.c |2 +- njs/njs_boolean.c|2 +- njs/njs_date.c

[njs] The "typeof" operation changes.

2017-03-28 Thread Igor Sysoev
details: http://hg.nginx.org/njs/rev/0bde7f156477 branches: changeset: 320:0bde7f156477 user: Igor Sysoev date: Sat Mar 25 13:42:40 2017 +0300 description: The "typeof" operation changes. diffstat: njs/njs_variable.c | 19 +++ njs/njs_vm.c | 7 ++- 2 f

[nginx] Fixed ngx_open_cached_file() error handling.

2017-03-28 Thread Sergey Kandaurov
details: http://hg.nginx.org/nginx/rev/3fb9b5eb75c0 branches: changeset: 6948:3fb9b5eb75c0 user: Sergey Kandaurov date: Tue Mar 28 14:21:38 2017 +0300 description: Fixed ngx_open_cached_file() error handling. If of.err is 0, it means that there was a memory allocation error and no f

[PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

2017-03-28 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1490516706 25200 # Sun Mar 26 01:25:06 2017 -0700 # Node ID ccb36c87291e38d1a63224d143cbeaa4ee4a4287 # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments. Signed-off-by: Piotr Sikora

Re: [PATCH] HTTP/2: reject HTTP/2 requests without ":scheme" pseudo-header

2017-03-28 Thread Piotr Sikora via nginx-devel
Hey Valentin, > This part of patch can be added to the style one: > > "HTTP/2: style and typos." Assuming that this patch gets dropped or even if it gets committed? > Is there any practical reason to force this restriction? None, other than following RFC and providing early detection of broke

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid ENABLE_PUSH setting value

2017-03-28 Thread Piotr Sikora via nginx-devel
Hey Valentin, > Is there any practical reason for the check considering that > the value is ignored anyway? None, other than following RFC and providing early detection of broken clients. Best regards, Piotr Sikora ___ nginx-devel mailing list nginx-de

Re: [PATCH] HTTP/2: emit PROTOCOL_ERROR on invalid WINDOW_UPDATE increments

2017-03-28 Thread Piotr Sikora via nginx-devel
Hey Valentin, > I'm not sure that strictly following RFC here is worth the effort. > > It seems there's no other "harm" from zero window updates except that it > allows to reset timers without any progress. That's only slightly worse > than 1-bytes window updates. Flow control interoperability a

[nginx] Core: set nginx_shared_zone name via ngx_str_set().

2017-03-28 Thread Ruslan Ermilov
details: http://hg.nginx.org/nginx/rev/a8d7c9139831 branches: changeset: 6947:a8d7c9139831 user: Ruslan Ermilov date: Tue Mar 28 11:28:51 2017 +0300 description: Core: set nginx_shared_zone name via ngx_str_set(). diffstat: src/event/ngx_event.c | 3 +-- 1 files changed, 1 insert

[nginx] Version bump.

2017-03-28 Thread Ruslan Ermilov
details: http://hg.nginx.org/nginx/rev/6e1a0a0d5f04 branches: changeset: 6945:6e1a0a0d5f04 user: Ruslan Ermilov date: Tue Mar 28 11:28:36 2017 +0300 description: Version bump. diffstat: src/core/nginx.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diffs (14 lines):

[nginx] Use ngx_array_init() to initialize arrays.

2017-03-28 Thread Ruslan Ermilov
details: http://hg.nginx.org/nginx/rev/99c87770b81b branches: changeset: 6946:99c87770b81b user: Ruslan Ermilov date: Tue Mar 28 11:28:42 2017 +0300 description: Use ngx_array_init() to initialize arrays. diffstat: src/core/ngx_cycle.c | 34 +++--- 1 f