Re: [PATCH] HTTP/2: add debug logging of control frames

2017-04-24 Thread Piotr Sikora via nginx-devel
Hey Valentin, > I actually agree with that, but let's try to reduce the size of printing. > > http2 send SETTINGS frame MAX_CONCURRENT_STREAMS > http2 send SETTINGS frame INITIAL_WINDOW_SIZE > http2 send SETTINGS frame MAX_FRAME_SIZE > > This looks like too verbose for just one SETTINGS

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers

2017-04-24 Thread Piotr Sikora via nginx-devel
Hey Valentin, > I think that pseudo-headers have different processing and shouldn't be > a part of the same block as normal http headers. That's why I prefer > the second variant: > > http2 pseudo-header: ":method: GET" Fair enough, patch updated. Best regards, Piotr Sikora

[PATCH] HTTP/2: add debug logging of pseudo-headers and cookies

2017-04-24 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 164b95f24f414359c5b8045415da3de82653c4db # Parent 2c4dbcd6f2e4c9c2a1eb8dc1f0d39c99975ae208 HTTP/2: add debug logging of pseudo-headers and cookies.

[PATCH 3 of 4] HTTP/2: make SETTINGS ACK frame reusable

2017-04-24 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1493073310 25200 # Mon Apr 24 15:35:10 2017 -0700 # Node ID b8d7f4a4d5abb4a27a772910358e263d49c618ef # Parent a8cfd4c454ff5433629bfd16444c6c71ee932fa1 HTTP/2: make SETTINGS ACK frame reusable. Signed-off-by: Piotr

[PATCH 2 of 4] HTTP/2: send SETTINGS ACK after applying all SETTINGS params

2017-04-24 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1493073310 25200 # Mon Apr 24 15:35:10 2017 -0700 # Node ID a8cfd4c454ff5433629bfd16444c6c71ee932fa1 # Parent 07adf0a7009c3244de4b795c0c06927f4316a87f HTTP/2: send SETTINGS ACK after applying all SETTINGS params. This

[PATCH 1 of 4] HTTP/2: emit new frames only after applying all SETTINGS params

2017-04-24 Thread Piotr Sikora via nginx-devel
# HG changeset patch # User Piotr Sikora # Date 1493073310 25200 # Mon Apr 24 15:35:10 2017 -0700 # Node ID 07adf0a7009c3244de4b795c0c06927f4316a87f # Parent 2c4dbcd6f2e4c9c2a1eb8dc1f0d39c99975ae208 HTTP/2: emit new frames only after applying all SETTINGS params.

Re: [nginx] Cleaned up r->headers_out.headers allocation error handling.

2017-04-24 Thread Maxim Dounin
Hello! On Mon, Apr 24, 2017 at 07:23:13PM +0300, Sorin Manole wrote: > >> For the Cache-Control header, the fix is to postpone pushing > >> r->headers_out.cache_control until its value is completed. > > Why not do the same thing for a bunch of other places like: > ngx_http_auth_basic_set_realm

Re: [PATCH] FYI: Fix FTBFS on Debian GNU/kFreeBSD

2017-04-24 Thread Maxim Dounin
Hello! On Mon, Apr 24, 2017 at 10:58:26AM +0900, HAYASHI Kentaro wrote: > Hi. > > I'm happy if the following patch is merged into upstream. > > nginx-kfreebsd.diff > > https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=826061;filename=nginx-kfreebsd.diff;msg=10 > > Here is more detail

[nginx] HTTP/2: reduced difference to HTTP/1.x in reading request body.

2017-04-24 Thread Valentin Bartenev
details: http://hg.nginx.org/nginx/rev/2c4dbcd6f2e4 branches: changeset: 6989:2c4dbcd6f2e4 user: Valentin Bartenev date: Mon Apr 24 14:17:13 2017 +0300 description: HTTP/2: reduced difference to HTTP/1.x in reading request body. Particularly, this eliminates