Re: [PATCH] Proxy: split configured header names and values

Hello! On Sat, Jun 03, 2017 at 08:04:00PM -0700, Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1489618535 25200 > # Wed Mar 15 15:55:35 2017 -0700 > # Node ID ff79d6887fc92d0344eac3e87339583265241e36 > # Parent

[njs] Object.getOwnPropertyDescriptor() method.

details: http://hg.nginx.org/njs/rev/cf6b4a543eea branches: changeset: 364:cf6b4a543eea user: Dmitry Volyntsev date: Tue Jun 13 17:52:11 2017 +0300 description: Object.getOwnPropertyDescriptor() method. diffstat: njs/njs_object.c | 151

Re: [nginx] Configure: use .exe for binaries for all win32 compilers.

On Tue, Jun 13, 2017 at 5:51 PM, Maxim Dounin wrote: > details: http://hg.nginx.org/nginx/rev/b7b7f3a0cc28 > branches: > changeset: 7031:b7b7f3a0cc28 > user: Orgad Shaneh > date: Tue Jun 06 19:37:34 2017 +0300 > description: > Configure: use .exe

[njs] Passing value and default attributes to njs_object_prop_alloc().

details: http://hg.nginx.org/njs/rev/8b5f5dbcbfe7 branches: changeset: 363:8b5f5dbcbfe7 user: Dmitry Volyntsev date: Tue Jun 13 17:49:05 2017 +0300 description: Passing value and default attributes to njs_object_prop_alloc(). diffstat: njs/njs_object.c | 26

[nginx] Configure: use .exe for binaries for all win32 compilers.

details: http://hg.nginx.org/nginx/rev/b7b7f3a0cc28 branches: changeset: 7031:b7b7f3a0cc28 user: Orgad Shaneh date: Tue Jun 06 19:37:34 2017 +0300 description: Configure: use .exe for binaries for all win32 compilers. diffstat: auto/cc/bcc | 1 - auto/cc/msvc

[nginx] Configure: fix compilation on MSYS2 / MinGW64.

details: http://hg.nginx.org/nginx/rev/4a343228c55e branches: changeset: 7030:4a343228c55e user: Orgad Shaneh date: Tue Jun 06 18:13:39 2017 +0300 description: Configure: fix compilation on MSYS2 / MinGW64. diffstat: auto/configure | 2 +- 1 files changed, 1

Re: slice module issue if redirected origin and have have fist slice

Hi George, On Tue, Jun 13, 2017 at 04:39:08PM +0300, George . wrote: > Hi Roman, > > Thank you a lot for detailed explanation. > Initially I thought that NGX_HTTP_SUBREQUEST_CLONE option to > ngx_http_subrequest (your latest fix in slice module - Slice filter: fetch > slices in cloned

Re: [PATCH] HTTP/2: reject HTTP/2 requests without ":scheme" pseudo-header

On Thursday 08 June 2017 20:45:18 Valentin V. Bartenev wrote: > On Wednesday 31 May 2017 15:48:34 Piotr Sikora via nginx-devel wrote: > > Hey Valentin, > > > > > As the 1.11 branch is going to be stable soon, it's a good idea to > > > postpone > > > any changes that explicitly affect

[nginx] HTTP/2: reject HTTP/2 requests without ":scheme" pseudo-header.

details: http://hg.nginx.org/nginx/rev/3c55863e6887 branches: changeset: 7029:3c55863e6887 user: Piotr Sikora date: Tue Jun 13 17:01:08 2017 +0300 description: HTTP/2: reject HTTP/2 requests without ":scheme" pseudo-header. Signed-off-by: Piotr Sikora

Re: slice module issue if redirected origin and have have fist slice

Hi Roman, Thank you a lot for detailed explanation. Initially I thought that NGX_HTTP_SUBREQUEST_CLONE option to ngx_http_subrequest (your latest fix in slice module - Slice filter: fetch slices in cloned subrequests) was intended to make full context in subrequest to be kept during redirects and

Re: [PATCH] HTTP/2: reject HTTP/2 requests with "Connection" header

Hey Valentin, > Since HTTP/2 is a separate protocol and not just GET / HTTP/2.0, so > the r->stream pointer should be tested instead (like in many other > places). Done. I've also sent few more patches rejecting remaining invalid headers. Feel free to squash them together if you prefer. Best

Re: [PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

Hey Valentin, > It's better to keep return values consistent with > ngx_http_v2_create_headers_frame() and introduce > NGX_HTTP_V2_NO_TRAILERS instead of NGX_HTTP_V2_FRAME_ERROR. NGX_HTTP_V2_NO_TRAILERS feels a bit weird, but whatever works for you is fine. > There's no reason to check

Re: [PATCH 1 of 3] Added support for trailers in HTTP responses

Hey Maxim, > I've tried this as well, and decided that "if (len == > sizeof(...))" is slightly more readable, and also produces smaller > patch to your code. No strict preference though, feel free to > use any variant you think is better. I've ended up using "if (len == 0) { ... }" in the end,

[PATCH 4 of 4] HTTP/2: reject HTTP/2 requests with connection-specific headers

# HG changeset patch # User Piotr Sikora # Date 1490516709 25200 # Sun Mar 26 01:25:09 2017 -0700 # Node ID e2abc3bc3fc12b788d2631d3c47215acdc4ebbe6 # Parent 6263d68cb96042d8f8974a4a3945226227ce13b9 HTTP/2: reject HTTP/2 requests with connection-specific headers.

[PATCH 3 of 4] HTTP/2: reject HTTP/2 requests with "Transfer-Encoding" header

# HG changeset patch # User Piotr Sikora # Date 1490516709 25200 # Sun Mar 26 01:25:09 2017 -0700 # Node ID 6263d68cb96042d8f8974a4a3945226227ce13b9 # Parent 349648a6f91f9bd5cc80d22390b95c2239a8bfb3 HTTP/2: reject HTTP/2 requests with "Transfer-Encoding" header.

[PATCH 3 of 3] Headers filter: added "add_trailer" directive

# HG changeset patch # User Piotr Sikora # Date 1490351854 25200 # Fri Mar 24 03:37:34 2017 -0700 # Node ID 46150fb672e7b92cfbe678bad71df187fcb25ae6 # Parent 73f67e06ab103e0368d1810c6f8cac5c70c4e246 Headers filter: added "add_trailer" directive. Trailers added using

[PATCH 1 of 4] HTTP/2: reject HTTP/2 requests with "Connection" header

# HG changeset patch # User Piotr Sikora # Date 1490516709 25200 # Sun Mar 26 01:25:09 2017 -0700 # Node ID 10c3f4c37f96ef496eff859b6f6815817e79455a # Parent e6f399a176e7cae0fa08f1183d31315bce3b9ecb HTTP/2: reject HTTP/2 requests with "Connection" header. While

[PATCH 2 of 3] HTTP/2: added support for trailers in HTTP responses

# HG changeset patch # User Piotr Sikora # Date 1490351854 25200 # Fri Mar 24 03:37:34 2017 -0700 # Node ID 73f67e06ab103e0368d1810c6f8cac5c70c4e246 # Parent 07a5d26b49f04425ff54cc998f885aa987b7823f HTTP/2: added support for trailers in HTTP responses.

[PATCH 2 of 4] HTTP/2: reject HTTP/2 requests with invalid "TE" header value

# HG changeset patch # User Piotr Sikora # Date 1490516709 25200 # Sun Mar 26 01:25:09 2017 -0700 # Node ID 349648a6f91f9bd5cc80d22390b95c2239a8bfb3 # Parent 10c3f4c37f96ef496eff859b6f6815817e79455a HTTP/2: reject HTTP/2 requests with invalid "TE" header value.

[PATCH 1 of 3] Added support for trailers in HTTP responses

# HG changeset patch # User Piotr Sikora # Date 1490351854 25200 # Fri Mar 24 03:37:34 2017 -0700 # Node ID 07a5d26b49f04425ff54cc998f885aa987b7823f # Parent e6f399a176e7cae0fa08f1183d31315bce3b9ecb Added support for trailers in HTTP responses. Example:

Re: slice module issue if redirected origin and have have fist slice

Hi George, On Mon, Jun 12, 2017 at 10:02:16AM +0300, George . wrote: > ​​Hi, > I've discovered following strange issue with http_slice_module > If I have a named location for internal 302 redirect and caching one slice > makes further request for whole object to brake upstream redirected request

[njs] Using nxt_lvlhsh_each_init() where appropriate.

details: http://hg.nginx.org/njs/rev/096d526744d5 branches: changeset: 362:096d526744d5 user: Dmitry Volyntsev date: Tue Jun 13 14:33:51 2017 +0300 description: Using nxt_lvlhsh_each_init() where appropriate. diffstat: njs/njs_generator.c | 3 +--