Re: [patch] Http image_filter: return 405 when method isHEADandbodyis empty.

2017-06-21 Thread 胡聪 (hucc)
So, the user will never know what happened on the backend (just get 415). Get it, thank you very much! -- Original -- From: "Maxim Dounin";; Send time: Thursday, Jun 22, 2017 1:24 AM To: "nginx-devel"; Subject: Re: [patch] Http image_filter: return 405 when metho

Re: [patch] Slice filter: support for empty file.

2017-06-21 Thread 胡聪 (hucc)
Hi, On Tuesday, Jun 20, 2017 11:01 PM +0300, Maxim Dounin wrote: >On Tue, Jun 20, 2017 at 10:39:44AM +0800, 胡聪 (hucc) wrote: > >> >416 will be returned when the request has no Range HEADER and the target >> >file is >> >empty. Apparently, it does not conform to the HTTP protocol. Empty file >>

Re: [patch] Http image_filter: return 405 when method is HEADandbodyis empty.

2017-06-21 Thread Maxim Dounin
Hello! On Thu, Jun 22, 2017 at 01:05:37AM +0800, 胡聪 (hucc) wrote: > Hi, > > On Wednesday, Jun 21, 2017 1:38 AM +0300, Maxim Dounin wrote: > > >When the response is read from a static file, not proxied, and/or > >proxied with "proxy_method GET;", an empty response means exacly > >that: an empty

Re: [patch] Http image_filter: return 405 when method is HEADandbodyis empty.

2017-06-21 Thread 胡聪 (hucc)
Hi, On Wednesday, Jun 21, 2017 1:38 AM +0300, Maxim Dounin wrote: >When the response is read from a static file, not proxied, and/or >proxied with "proxy_method GET;", an empty response means exacly >that: an empty response, and returning 415 is perfectly correct. > >The ngx_buf_size() test will