Re: [PATCH 0 of 2] unbuffered proxying CPU hog (ticket #2418)

2022-11-30 Thread Maxim Dounin
Hello! On Wed, Nov 30, 2022 at 07:29:35PM +0400, Sergey Kandaurov wrote: > > On 29 Nov 2022, at 02:12, Maxim Dounin wrote: > > > > Hello! > > > > The following patch fixes CPU hog observed with unbuffered SSL proxying > > after SSL errors (ticket #2418). Fix is to always clear

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-30 Thread Maxim Dounin
Hello! On Wed, Nov 30, 2022 at 11:49:18AM +0100, Alex Colomar wrote: > On 11/30/22 05:22, Maxim Dounin wrote: > > Hello! > > > > Ping. > > Sorry, I didn't know you were waiting for my confirmation. Not exactly yours. As per the project policy, patches need to be approved by other core

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-30 Thread Maxim Dounin
Hello! On Wed, Nov 30, 2022 at 04:17:15PM +0400, Sergey Kandaurov wrote: > On Wed, Nov 09, 2022 at 06:03:24PM +0300, Maxim Dounin wrote: > > # HG changeset patch > > # User Maxim Dounin > > # Date 1668004692 -10800 > > # Wed Nov 09 17:38:12 2022 +0300 > > # Node ID

RE: [PATCH] HTTP: add internal_redirect directive.

2022-11-30 Thread Aleksei Bavshin via nginx-devel
Hello, > > The directive in question provides direct access to the > > ngx_http_internal_redirect/ngx_http_named_location APIs, > > allowing to simplify and optimize several real-life > > configurations where the modules should be executed multiple > > times/in a different order/with a different

Re: [PATCH 0 of 2] unbuffered proxying CPU hog (ticket #2418)

2022-11-30 Thread Sergey Kandaurov
> On 29 Nov 2022, at 02:12, Maxim Dounin wrote: > > Hello! > > The following patch fixes CPU hog observed with unbuffered SSL proxying > after SSL errors (ticket #2418). Fix is to always clear c->read->ready > flag when returning errors from ngx_ssl_recv(). > > An additional patch cleans

Re: QUIC: position of RTT and congestion

2022-11-30 Thread Vladimir Homutov via nginx-devel
On Wed, Nov 30, 2022 at 08:10:29PM +0800, Yu Zhu wrote: > > Hi, > > As described in "rfc 9002 6. Loss Detection", "RTT and congestion > control are properties of the path", so moves first_rtt, > latest_rtt, avg_rtt, min_rtt, rttvar and congestion from > ngx_quic_connection_t to

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-30 Thread Sergey Kandaurov
On Wed, Nov 09, 2022 at 06:03:24PM +0300, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1668004692 -10800 > # Wed Nov 09 17:38:12 2022 +0300 > # Node ID fc79ea0724a92c1f463625a11ed4cb785cd342b7 > # Parent 42bc158a47ecb3c2bd0396c723c307c757f2770e > Fixed alignment

QUIC: position of RTT and congestion

2022-11-30 Thread Yu Zhu
Hi, As described in "rfc 9002 6. Loss Detection", "RTT and congestion control are properties of the path", so moves first_rtt, latest_rtt, avg_rtt, min_rtt, rttvar and congestion from ngx_quic_connection_t to struct ngx_quic_path_t looks more reasonable? -- Yu

Re: [PATCH v2] Removed the casts within ngx_memcmp()

2022-11-30 Thread Alex Colomar
Hello Maxim! On 11/30/22 05:22, Maxim Dounin wrote: Hello! Ping. Sorry, I didn't know you were waiting for my confirmation. On Wed, Nov 09, 2022 at 06:03:24PM +0300, Maxim Dounin wrote: [...] # HG changeset patch # User Maxim Dounin # Date 1668004692 -10800 # Wed Nov 09 17:38:12

Re: [PATCH 08 of 10] QUIC: idle mode for main connection

2022-11-30 Thread Roman Arutyunyan
Hi, On Tue, Nov 29, 2022 at 06:00:40PM +0400, Roman Arutyunyan wrote: > Hi, > > On Mon, Nov 28, 2022 at 09:40:05PM +0400, Sergey Kandaurov wrote: > > On Thu, Nov 24, 2022 at 07:15:31PM +0400, Roman Arutyunyan wrote: > > > Hi, > > > > > > On Thu, Oct 20, 2022 at 06:25:03PM +0400, Roman